Revert "Revert "Unify boringssl submodules and use non-developer bori…

…ngssl cmake build""

This reverts commit fe2242e.

.clang_complete

@@ -6,7 +6,7 @@
 -Isrc/core/ext/upb-generated
 -Ithird_party/abseil-cpp
 -Ithird_party/benchmark/include
--Ithird_party/boringssl/include
+-Ithird_party/boringssl-with-bazel/src/include
 -Ithird_party/cares
 -Ithird_party/cares/cares
 -Ithird_party/googletest

.gitmodules

@@ -15,9 +15,6 @@
 [submodule "third_party/googletest"]
 	path = third_party/googletest
 	url = https://github.com/google/googletest.git
-[submodule "third_party/boringssl"]
-	path = third_party/boringssl
-	url = https://github.com/google/boringssl.git
 [submodule "third_party/benchmark"]
 	path = third_party/benchmark
 	url = https://github.com/google/benchmark

BUILDING.md

@@ -56,8 +56,6 @@ To prepare for cmake + Microsoft Visual C++ compiler build
 - Install Visual Studio 2015 or 2017 (Visual C++ compiler will be used).
 - Install [Git](https://git-scm.com/).
 - Install [CMake](https://cmake.org/download/).
-- Install [Active State Perl](https://www.activestate.com/activeperl/) (`choco install activeperl`) - *required by boringssl*
-- Install [Go](https://golang.org/dl/) (`choco install golang`) - *required by boringssl*
 - Install [nasm](https://www.nasm.us/) and add it to `PATH` (`choco install nasm`) - *required by boringssl*
 - (Optional) Install [Ninja](https://ninja-build.org/) (`choco install ninja`)
 

PYTHON-MANIFEST.in

@@ -6,7 +6,7 @@ graft src/boringssl
 graft include/grpc
 graft third_party/abseil-cpp/absl
 graft third_party/address_sorting
-graft third_party/boringssl
+graft third_party/boringssl-with-bazel
 graft third_party/cares
 graft third_party/upb
 graft third_party/zlib

bazel/grpc_deps.bzl

@@ -131,7 +131,7 @@ def grpc_deps():
             name = "boringssl",
             # NOTE: This URL generates a tarball containing dynamic date
             # information, so the sha256 is not consistent.
-            url = "https://boringssl.googlesource.com/boringssl/+archive/83da28a68f32023fd3b95a8ae94991a07b1f6c62.tar.gz",
+            url = "https://boringssl.googlesource.com/boringssl/+archive/1ef2e8834b845cb47dbdceec6a676722bcf0062b.tar.gz",
         )
 
     if "zlib" not in native.existing_rules():

build.yaml

@@ -6286,7 +6286,7 @@ defaults:
     CPPFLAGS: -Ithird_party/benchmark/include -DHAVE_POSIX_REGEX
   boringssl:
     CFLAGS: -g
-    CPPFLAGS: -Ithird_party/boringssl/include -fvisibility=hidden -DOPENSSL_NO_ASM
+    CPPFLAGS: -Ithird_party/boringssl-with-bazel/src/include -fvisibility=hidden -DOPENSSL_NO_ASM
       -D_GNU_SOURCE -DWIN32_LEAN_AND_MEAN -D_HAS_EXCEPTIONS=0 -DNOMINMAX
     CXXFLAGS: -fno-exceptions
   global:

cmake/ssl.cmake

@@ -18,7 +18,7 @@
 
 if(gRPC_SSL_PROVIDER STREQUAL "module")
   if(NOT BORINGSSL_ROOT_DIR)
-    set(BORINGSSL_ROOT_DIR ${CMAKE_CURRENT_SOURCE_DIR}/third_party/boringssl)
+    set(BORINGSSL_ROOT_DIR ${CMAKE_CURRENT_SOURCE_DIR}/third_party/boringssl-with-bazel)
   endif()
 
   if(EXISTS "${BORINGSSL_ROOT_DIR}/CMakeLists.txt")
@@ -40,10 +40,10 @@ if(gRPC_SSL_PROVIDER STREQUAL "module")
       endif()
     endif()
 
-    add_subdirectory(${BORINGSSL_ROOT_DIR} third_party/boringssl)
+    add_subdirectory(${BORINGSSL_ROOT_DIR} third_party/boringssl-with-bazel)
     if(TARGET ssl)
-      set(_gRPC_SSL_LIBRARIES ssl)
-      set(_gRPC_SSL_INCLUDE_DIR ${BORINGSSL_ROOT_DIR}/include)
+      set(_gRPC_SSL_LIBRARIES ssl crypto)
+      set(_gRPC_SSL_INCLUDE_DIR ${BORINGSSL_ROOT_DIR}/src/include)
       if(gRPC_INSTALL AND _gRPC_INSTALL_SUPPORTED_FROM_MODULE)
         install(TARGETS ssl crypto EXPORT gRPCTargets
           RUNTIME DESTINATION ${gRPC_INSTALL_BINDIR}

gRPC-Core.podspec

@@ -170,7 +170,7 @@ Pod::Spec.new do |s|
     ss.header_mappings_dir = '.'
     ss.libraries = 'z'
     ss.dependency "#{s.name}/Interface", version
-    ss.dependency 'BoringSSL-GRPC', '0.0.5'
+    ss.dependency 'BoringSSL-GRPC', '0.0.6'
     abseil_version = '0.20190808.1'
     ss.dependency 'abseil/container/inlined_vector', abseil_version
     ss.dependency 'abseil/strings/strings', abseil_version

setup.py

@@ -51,7 +51,7 @@
   CARES_INCLUDE += (os.path.join('third_party', 'cares', 'config_linux'),)
 if 'openbsd' in sys.platform:
   CARES_INCLUDE += (os.path.join('third_party', 'cares', 'config_openbsd'),)
-SSL_INCLUDE = (os.path.join('third_party', 'boringssl', 'include'),)
+SSL_INCLUDE = (os.path.join('third_party', 'boringssl-with-bazel', 'src', 'include'),)
 UPB_INCLUDE = (os.path.join('third_party', 'upb'),)
 UPB_GRPC_GENERATED_INCLUDE = (os.path.join('src', 'core', 'ext', 'upb-generated'),)
 ZLIB_INCLUDE = (os.path.join('third_party', 'zlib'),)

src/boringssl/gen_build_yaml.py

@@ -22,7 +22,8 @@
 sys.dont_write_bytecode = True
 
 boring_ssl_root = os.path.abspath(
-    os.path.join(os.path.dirname(sys.argv[0]), '../../third_party/boringssl'))
+    os.path.join(os.path.dirname(sys.argv[0]),
+                 '../../third_party/boringssl-with-bazel/src'))
 sys.path.append(os.path.join(boring_ssl_root, 'util'))
 
 try:
@@ -33,15 +34,13 @@
 
 
 def map_dir(filename):
-    if filename[0:4] == 'src/':
-        return 'third_party/boringssl/' + filename[4:]
-    else:
-        return 'src/boringssl/' + filename
+    return 'third_party/boringssl-with-bazel/' + filename
 
 
+# TODO(jtattermusch): is this used at all?
 def map_testarg(arg):
     if '/' in arg:
-        return 'third_party/boringssl/' + arg
+        return 'third_party/boringssl-with-bazel/src' + arg
     else:
         return arg