temporary_buffer: make nothrow default constructible

Required for making iostreams nothrow move constructible. Note that it is already nothrow_move_constructible. Signed-off-by: Benny Halevy <[email protected]>
longlene · Jun 7, 2020 · 3b8a6bc · 3b8a6bc
1 parent e83293c
commit 3b8a6bc
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/include/seastar/core/temporary_buffer.hh b/include/seastar/core/temporary_buffer.hh
@@ -78,7 +78,7 @@ public:
     }
     //explicit temporary_buffer(CharType* borrow, size_t size) : _buffer(borrow), _size(size) {}
     /// Creates an empty \c temporary_buffer that does not point at anything.
-    temporary_buffer()
+    temporary_buffer() noexcept
         : _buffer(nullptr)
         , _size(0) {}
     temporary_buffer(const temporary_buffer&) = delete;

diff --git a/src/core/fstream.cc b/src/core/fstream.cc
@@ -37,6 +37,9 @@ static_assert(std::is_nothrow_move_constructible_v<data_source>);
 static_assert(std::is_nothrow_constructible_v<data_sink>);
 static_assert(std::is_nothrow_move_constructible_v<data_sink>);
 
+static_assert(std::is_nothrow_constructible_v<temporary_buffer<char>>);
+static_assert(std::is_nothrow_move_constructible_v<temporary_buffer<char>>);
+
 class file_data_source_impl : public data_source_impl {
     struct issued_read {
         uint64_t _pos;