Skip to content

Commit

Permalink
Visual Studio Code is no longer responding microsoft#160
Browse files Browse the repository at this point in the history
  • Loading branch information
aeschli committed Nov 21, 2015
1 parent 47eb735 commit c89555b
Showing 1 changed file with 1 addition and 7 deletions.
8 changes: 1 addition & 7 deletions extensions/php/src/features/signatureHelpProvider.ts
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ class BackwardIterator {
this.offset = this.line.length - 1;
return _NL;
}
this.lineNumber = 0;
this.lineNumber = -1;
return BOF;
}
var ch = this.line.charCodeAt(this.offset);
Expand All @@ -70,24 +70,20 @@ class BackwardIterator {
export default class PHPSignatureHelpProvider implements SignatureHelpProvider {

public provideSignatureHelp(document: TextDocument, position: Position, token: CancellationToken): Promise<SignatureHelp> {
console.log('provideSignatureHelp');
var iterator = new BackwardIterator(document, position.character - 1, position.line);

var paramCount = this.readArguments(iterator);
if (paramCount < 0) {
console.log('paramCount ' + 0);
return null;
}

var ident = this.readIdent(iterator);
if (!ident) {
console.log('ident ' + ident);
return null;
}

var entry = phpGlobals.globalfunctions[ident] || phpGlobals.keywords[ident];
if (!entry || !entry.signature) {
console.log('no entry ');
return null;
}
var paramsString = entry.signature.substring(0, entry.signature.lastIndexOf(')') + 1);
Expand All @@ -98,12 +94,10 @@ export default class PHPSignatureHelpProvider implements SignatureHelpProvider {
while ((match = re.exec(paramsString)) !== null) {
signatureInfo.parameters.push({ label: match[0], documentation: ''});
}

let ret = new SignatureHelp();
ret.signatures.push(signatureInfo);
ret.activeSignature = 0;
ret.activeParameter = Math.min(paramCount, signatureInfo.parameters.length - 1);
console.log(ret);
return Promise.resolve(ret);
}

Expand Down

0 comments on commit c89555b

Please sign in to comment.