fix(details): visual sloppy #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lowlighter
reviewed
May 28, 2024
styles/collapsibles/mod.css
Outdated
| @@ -24,6 +24,7 @@ details[open] > summary { | |||
| margin: -1rem; | |||
| margin-bottom: 1rem; | |||
| background: var(--bg-muted); | |||
| border-radius: calc(var(--bd-radius) - 1px) calc(var(--bd-radius) - 1px) 0 0; | |||
There was a problem hiding this comment.
Wouldn't it be better to put it directly on summary so if the background color of summary is overriden there's no issue too ?
There was a problem hiding this comment.
Yes! You right! I moved that line in summary declaration. 👍
lowlighter
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After:
Why i use calc?
Without calc inner and outer radii does not equal
see more: https://css-tricks.com/public-service-announcement-careful-with-your-nested-border-radii/