Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Add HTTPS handling and logging for LoxiLB based on --loxiURL co… #186

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

PR: Add HTTPS handling and logging for LoxiLB based on --loxiURL co… #186

wants to merge 1 commit into from
+35 −2

Conversation

sososo0
Copy link

@sososo0 sososo0 commented Oct 11, 2024

Related Issue : #34

Summary

  • Checking --loxiURL in the config to determine HTTP or HTTPS
  • Handling HTTPS requests when making REST API calls
  • Logging when HTTPS is not supported in LoxiLB

@CLAassistant
Copy link

CLAassistant commented Oct 11, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

TrekkieCoder
TrekkieCoder requested changes Oct 11, 2024
View reviewed changes
Copy link
Collaborator

@TrekkieCoder TrekkieCoder left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look fine. However kube-loxilb README also need to be changed to mention about availability of https.

How has these changes been tested ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TrekkieCoder TrekkieCoder TrekkieCoder requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sososo0 @CLAassistant @TrekkieCoder