fix leftover nitpicks (vercel#2581)

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
lucas8 · Nov 8, 2022 · 72f8fcc · 72f8fcc
1 parent 79e6c31
commit 72f8fcc
Show file tree

Hide file tree

Showing 17 changed files with 34 additions and 66 deletions.
diff --git a/crates/turbopack-dev-server/src/source/mod.rs b/crates/turbopack-dev-server/src/source/mod.rs
@@ -269,8 +269,8 @@ pub trait ContentSource {
     /// Gets content by `path` and request `data` from the source. `data` is
     /// empty by default and will only be filled when returning `NeedData`.
     /// This is useful as this method call will be cached based on it's
-    /// arguments, so we want to make the arguments contain as few information
-    /// as possible to increase cache hit ratio.
+    /// arguments, so we want to make the arguments contain as little
+    /// information as possible to increase cache hit ratio.
     fn get(&self, path: &str, data: Value<ContentSourceData>) -> ContentSourceResultVc;
 }
 

diff --git a/crates/turbopack-ecmascript/js/src/runtime.js b/crates/turbopack-ecmascript/js/src/runtime.js
@@ -148,10 +148,8 @@
   function interopEsm(raw, ns, allowExportDefault) {
     /** @type {Object.<string, () => any>} */
     const getters = { __proto__: null };
-    if (typeof raw === "object" || typeof raw === "function") {
-      for (const key in raw) {
-        getters[key] = createGetter(raw, key);
-      }
+    for (const key in raw) {
+      getters[key] = createGetter(raw, key);
     }
     if (!(allowExportDefault && "default" in getters)) {
       getters["default"] = () => raw;

diff --git a/...hunk/output/crates_turbopack-tests_tests_snapshot_basic_async_chunk_input_index_9be35c.js b/...hunk/output/crates_turbopack-tests_tests_snapshot_basic_async_chunk_input_index_9be35c.js
diff --git a/.../chunked/output/crates_turbopack-tests_tests_snapshot_basic_chunked_input_index_b11d49.js b/.../chunked/output/crates_turbopack-tests_tests_snapshot_basic_chunked_input_index_b11d49.js
diff --git a/...apshot/css/css/output/crates_turbopack-tests_tests_snapshot_css_css_input_index_907a50.js b/...apshot/css/css/output/crates_turbopack-tests_tests_snapshot_css_css_input_index_907a50.js
diff --git a/...motion/output/crates_turbopack-tests_tests_snapshot_emotion_emotion_input_index_b6dbf3.js b/...motion/output/crates_turbopack-tests_tests_snapshot_emotion_emotion_input_index_b6dbf3.js
diff --git a/...sts/snapshot/env/env/output/crates_turbopack-tests_tests_snapshot_env_env_input_480486.js b/...sts/snapshot/env/env/output/crates_turbopack-tests_tests_snapshot_env_env_input_480486.js
diff --git a/...me_entry/output/a587c_tests_snapshot_evaluated_entrry_runtime_entry_input_index_50fbca.js b/...me_entry/output/a587c_tests_snapshot_evaluated_entrry_runtime_entry_input_index_50fbca.js
diff --git a/...xample/output/crates_turbopack-tests_tests_snapshot_example_example_input_index_a7beb7.js b/...xample/output/crates_turbopack-tests_tests_snapshot_example_example_input_index_a7beb7.js
diff --git a/...orts/json/output/crates_turbopack-tests_tests_snapshot_imports_json_input_index_e24981.js b/...orts/json/output/crates_turbopack-tests_tests_snapshot_imports_json_input_index_e24981.js
diff --git a/...tput/79fb1_turbopack-tests_tests_snapshot_imports_resolve_error_cjs_input_index_e00120.js b/...tput/79fb1_turbopack-tests_tests_snapshot_imports_resolve_error_cjs_input_index_e00120.js
diff --git a/...tput/79fb1_turbopack-tests_tests_snapshot_imports_resolve_error_esm_input_index_1a5dd4.js b/...tput/79fb1_turbopack-tests_tests_snapshot_imports_resolve_error_esm_input_index_1a5dd4.js
diff --git a/.../static/output/crates_turbopack-tests_tests_snapshot_imports_static_input_index_b8717b.js b/.../static/output/crates_turbopack-tests_tests_snapshot_imports_static_input_index_b8717b.js
diff --git a/...nts/output/a587c_tests_snapshot_styled_components_styled_components_input_index_7b57d9.js b/...nts/output/a587c_tests_snapshot_styled_components_styled_components_input_index_7b57d9.js
diff --git a/...ut/a587c_tests_snapshot_swc_transforms_mono_transforms_input_packages_app_index_739f58.js b/...ut/a587c_tests_snapshot_swc_transforms_mono_transforms_input_packages_app_index_739f58.js
diff --git a/...tput/79fb1_turbopack-tests_tests_snapshot_swc_transforms_preset_env_input_index_44c34f.js b/...tput/79fb1_turbopack-tests_tests_snapshot_swc_transforms_preset_env_input_index_44c34f.js
diff --git a/...seurl/output/crates_turbopack-tests_tests_snapshot_tsconfig_baseurl_input_index_5906e5.js b/...seurl/output/crates_turbopack-tests_tests_snapshot_tsconfig_baseurl_input_index_5906e5.js