Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(icons): add Saudi Riyal Symbol #2827

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

Null78
Copy link

@Null78 Null78 commented Feb 20, 2025

What is the purpose of this pull request?

  • New Icon
  • Bug fix
  • New Feature
  • Documentation update
  • Other:

Description

This PR introduces a new icon for the Saudi Riyal (SAR) currency symbol. The Saudi Riyal symbol was officially approved by the Saudi Central Bank (SAMA) on February 20, 2025. More information about the symbol can be found on SAMA's official website.

Icon use case

The Saudi Riyal icon can be used in a variety of financial and e-commerce applications. Examples include:

  1. Currency conversion tools and financial dashboards displaying SAR values.
  2. Online shopping platforms and payment gateways to indicate transactions in SAR.

Alternative icon designs

N/A

Icon Design Checklist

Concept

  • I have provided valid use cases for each icon.
  • I have not added any a brand or logo icon.
  • I have not used any hate symbols.
  • I have not included any religious or political imagery.

Author, credits & license

  • The icons are solely my own creation.
  • The icons were originally created in # by @
  • I've based them on the following Lucide icons:
  • I've based them on the following design: SAMA's official website

Naming

  • I've read and followed the naming conventions.
  • I've named icons by what they are rather than their use case.
  • I've provided meta JSON files in icons/[iconName].json.

Design

  • I've read and followed the icon design guidelines.
  • I've made sure that the icons look sharp on low DPI displays.
  • I've made sure that the icons look consistent with the icon set in size, optical volume, and density.
  • I've made sure that the icons are visually centered.
  • I've correctly optimized all icons to three points of precision.

Before Submitting

@jguddas
Copy link
Member

jguddas commented Feb 20, 2025

icons
Open lucide studio

Co-authored-by: Jakob Guddas <[email protected]>
@github-actions github-actions bot added 🎨 icon About new icons 🫧 metadata Improved metadata labels Feb 20, 2025
@Null78 Null78 changed the title feat(icons): add Saudi Riyal Sign feat(icons): add Saudi Riyal Symbol Feb 20, 2025
@jguddas
Copy link
Member

jguddas commented Feb 20, 2025

Name should IMO not include -symbol.

- icons/saudi-riyal-symbol.json
+ icons/saudi-riyal.json

@Null78
Copy link
Author

Null78 commented Feb 20, 2025

Name should IMO not include -symbol.

- icons/saudi-riyal-symbol.json
+ icons/saudi-riyal.json

i see your point @jguddas, but i thought we should follow the official name by SAMA (Saudi Riyal Symbol), i can change it to sign or remove it, if it will make the approval process easier

@Null78
Copy link
Author

Null78 commented Feb 21, 2025

removed symbol from the icon name 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 icon About new icons 🫧 metadata Improved metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants