Stacked on Bazel 8 upgrade: multiplex sandbox bug fix and a few other things #84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
February 19, 2025 22:28
These were sourced from the Bazel 8 release page: https://github.com/bazelbuild/bazel/releases/tag/8.0.0
Bazel 8 deprecates the rulesets bundled with Bazel (which includes the Protobuf rules) in favor of their Starlark-ified equivalents. For that reason, we switch to the `protobuf` ruleset for `proto_library` and `java_proto_library`. In doing so, we can't use `com.github.os72:protoc-jar` because the version of protoc it bundles is extremely out of date and incompatible with the version of protobuf provided by the Starlark-ified protobuf ruleset. In its place, we use the protoc provided by that ruleset.
v0.7.1 doesn't use the Starlark-ified protobuf rules.
…ction_env The former is deprecated and has been replaced with the latter.
jjudd
force-pushed
the
test-custom-bazel-version
branch
7 times, most recently
from
f0c0f72 to
c0c6f76
Compare
Some of the code we produce gets used as libraries by other rule sets, so we should prefer the LTS over the Next branch.
jjudd
force-pushed
the
test-custom-bazel-version
branch
from
c0c6f76 to
58c69b1
Compare
jjudd
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses the custom version of Bazel with the multiplex sandbox bug fix as well as upgrading a few things and making a few other improvements.