Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for multiple score types in local storage. #8

Closed
wants to merge 1 commit into from

Conversation

andyperlitch
Copy link
Contributor

Also fixes #4.

@andyperlitch
Copy link
Contributor Author

Sigh... these minified build files are killing me, and my pull requests... I see that you guys have set up a develop branch that I am guessing is intended to fix this problem of merge conflicts due to the build/ directory. Can you please advise as to what I should do? I would really like to contribute but you guys either have to get better at merging PRs before updating, or use the develop branch in the way I describe above.

@karliky karliky self-assigned this Oct 24, 2014
@karliky
Copy link
Contributor

karliky commented Oct 24, 2014

Hey Andy,

We have to update the content of build/ every time we do an update of our plugins because that files are used by everyone that want to use our plugins. sorry for that.

I will integrate your fix in the next release, next week.

Thank you for your time

@andyperlitch
Copy link
Contributor Author

Were you guys planning on using the develop branch at all? If the build directory was only tracked in master and created with releases (or on merges from develop -> master), this problem wouldn't occur. You'd probably end up getting more free help from people like me :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

proxifyConsole is used in cocoon_webview.js but never defined
2 participants