libcamera: transform: Make the transformFromOrientation() function st…

…atic Now that the transformFromOrientation() function isn't used outside of transform.cpp, make it static to remove it from the public API. Signed-off-by: Laurent Pinchart <[email protected]> Reviewed-by: Jacopo Mondi <[email protected]>
lukeclements · Oct 23, 2023 · fd98779 · fd98779
1 parent 53b4419
commit fd98779
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/include/libcamera/transform.h b/include/libcamera/transform.h
@@ -71,7 +71,6 @@ constexpr Transform operator~(Transform t)
 }
 
 Transform transformFromRotation(int angle, bool *success = nullptr);
-Transform transformFromOrientation(const Orientation &orientation);
 
 Transform operator/(const Orientation &o1, const Orientation &o2);
 Orientation operator*(const Orientation &o, const Transform &t);

diff --git a/src/libcamera/transform.cpp b/src/libcamera/transform.cpp
@@ -301,6 +301,8 @@ Transform transformFromRotation(int angle, bool *success)
 	return Transform::Identity;
 }
 
+namespace {
+
 /**
  * \brief Return the transform representing \a orientation
  * \param[in] orientation The orientation to convert
@@ -330,6 +332,8 @@ Transform transformFromOrientation(const Orientation &orientation)
 	return Transform::Identity;
 }
 
+} /* namespace */
+
 /**
  * \brief Return the Transform that applied to \a o2 gives \a o1
  * \param o1 The Orientation to obtain