Added indeterminate feature #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the indeterminate prop to enhancedSwitch which adds the appropriate indeterminate class and then attempts to set the input to indeterminate onMount and onUpdate.
|
CI checks have failed |
|
Ran the linter and tests and fixed it. |
| key: 'setIndeterminate', | ||
| value: function setIndeterminate() { | ||
| if (this.props.indeterminate) { | ||
| this.refs.checkbox.indetermiante = true; |
There was a problem hiding this comment.
"indetermiante"? This is broken -- there is no "indetermiante" property on dom checkbox elements. Now, "indeterminate" is a different story...
There was a problem hiding this comment.
@dclowd9901 Good catch. This is what happens when you have to write indeterminate way too may times. Created a PR to fix it
There was a problem hiding this comment.
Happy to help :) using a self made polyfill now, so I'm def looking forward to this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the indeterminate prop to enhancedSwitch which adds the
appropriate indeterminate class and then attempts to set the input to
indeterminate onMount and onUpdate.
See facebook/react#1798 for discussion about setting indeterminate with react.