Tweaks to word cloud controls (apache#7212)

lussong · Apr 8, 2019 · 442cfc6 · 442cfc6
1 parent 5ef2712
commit 442cfc6
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 4 deletions.
diff --git a/superset/assets/src/explore/controlPanels/WordCloud.js b/superset/assets/src/explore/controlPanels/WordCloud.js
@@ -17,6 +17,7 @@
  * under the License.
  */
 import { t } from '@superset-ui/translation';
+import { nonEmpty } from '../validators';
 
 export default {
   controlPanelSections: [
@@ -32,11 +33,27 @@ export default {
     },
     {
       label: t('Options'),
+      expanded: true,
       controlSetRows: [
         ['size_from', 'size_to'],
         ['rotation'],
         ['color_scheme'],
       ],
     },
   ],
+  controlOverrides: {
+    series: {
+      validators: [nonEmpty],
+      clearable: false,
+    },
+    row_limit: {
+      default: 100,
+    },
+    size_from: {
+      default: 10,
+    },
+    size_to: {
+      default: 70,
+    },
+  },
 };
diff --git a/superset/assets/src/explore/controls.jsx b/superset/assets/src/explore/controls.jsx
@@ -1300,10 +1300,11 @@ export const controls = {
 
   rotation: {
     type: 'SelectControl',
-    label: t('Rotation'),
+    label: t('Word Rotation'),
     choices: formatSelectOptions(['random', 'flat', 'square']),
     renderTrigger: true,
-    default: 'flat',
+    default: 'square',
+    clearable: false,
     description: t('Rotation to apply to words in the cloud'),
   },
 
@@ -1385,7 +1386,7 @@ export const controls = {
   size_from: {
     type: 'TextControl',
     isInt: true,
-    label: t('Font Size From'),
+    label: t('Minimum Font Size'),
     renderTrigger: true,
     default: '20',
     description: t('Font size for the smallest value in the list'),
@@ -1394,7 +1395,7 @@ export const controls = {
   size_to: {
     type: 'TextControl',
     isInt: true,
-    label: t('Font Size To'),
+    label: t('Maximum Font Size'),
     renderTrigger: true,
     default: '150',
     description: t('Font size for the biggest value in the list'),