Fix a leak with DtlsFactory; a new instance is being created for every s... #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y single DtlsClient/Server creation, but the factory was never being destroyed. Also some various cleanup--remove unnecessary setSocket call (was already being done through setDtlsSocket), make some code a bit more readable, etc.
|
Thanks! |
|
No problem--my pleasure. |
|
Thank you jnoring, how can I get in touch with you? |
|
I think my email address is listed in github? If not, [email protected] is where I'd check email. google chat works. Some issue with my changset? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...ingle DtlsClient/Server creation, but the factory was never being destroyed.
Also some various cleanup--remove unnecessary setSocket call (was already being done through setDtlsSocket), make some code a bit more readable, pre-increment iterators, etc.