Skip to content

Commit

Permalink
Update contributing guidelines on metrics (spiffe#3043)
Browse files Browse the repository at this point in the history
Fixes: spiffe#1005

Signed-off-by: Andrew Harding <[email protected]>
  • Loading branch information
azdagron authored May 9, 2022
1 parent 3ae358f commit 9cb861e
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,8 @@ specific metrics should be centrally defined in the `telemetry` package or its s
desiring metrics should delegate counter, gauge, timer, etc. creation to such packages.
The metrics emitted by SPIRE are listed in the [telemetry document](doc/telemetry.md) and should be kept up to date.

In addition, metrics should be unit-tested where reasonable.

### Count in Aggregate

Event count metrics should aggregate where possible to reduce burden on metric sinks, infrastructure,
Expand Down

0 comments on commit 9cb861e

Please sign in to comment.