Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ruby34: New version #27210

Merged
merged 1 commit into from
Jan 13, 2025
Merged

ruby34: New version #27210

merged 1 commit into from
Jan 13, 2025

Conversation

fhgwright
Copy link
Contributor

@fhgwright fhgwright commented Dec 26, 2024 •
edited
Loading

See:
https://www.ruby-lang.org/en/news/2024/12/25/ruby-3-4-1-released/

TESTED:
Pending.

Description

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on
Mac OS X 10.4.11 8S165, PPC, Xcode 2.5 8M2558
Mac OS X 10.4.11 8S2167, i386, Xcode 2.5 8M2558
Mac OS X 10.5.8 9L31a, PPC, Xcode 3.1.4 9M2809
Mac OS X 10.5.8 9L31a, i386, Xcode 3.1.4 9M2809
Mac OS X 10.5.8 9L31a, x86_64, Xcode 3.1.4 9M2809
Mac OS X 10.6.8 10K549, i386, Xcode 3.2.6 10M2518
Mac OS X 10.6.8 10K549, x86_64, Xcode 3.2.6 10M2518
Mac OS X 10.7.5 11G63, x86_64, Xcode 4.6.3 4H1503
OS X 10.8.5 12F2560, x86_64, Xcode 5.1.1 5B1008
OS X 10.9.5 13F1911, x86_64, Xcode 6.2 6C131e
OS X 10.10.5 14F2511, x86_64, Xcode 7.2 7C68
OS X 10.11.6 15G22010, x86_64, Xcode 8.1 8B62
macOS 10.12.6 16G2136, x86_64, Xcode 9.2 9C40b
macOS 10.13.6 17G14042, x86_64, Xcode 10.1 10B61
macOS 10.14.6 18G9323, x86_64, Xcode 11.3.1 11C505
macOS 10.15.7 19H15, x86_64, Xcode 12.4 12D4e
macOS 11.7.10 20G1427, x86_64, Xcode 13.2.1 13C100
macOS 11.7.10 20G1427, arm64, Xcode 13.2.1 13C100
macOS 12.7.6 21H1320, x86_64, Xcode 14.2 14C18
macOS 12.7.6 21H1320, arm64, Xcode 14.2 14C18
macOS 13.7.2 22H313, arm64, Xcode 15.2 15C500b
macOS 14.7.2 23H311, arm64, Xcode 16.2 16C5032a
macOS 15.2 24C101, arm64, Xcode 16.2 16C5032a
Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • [N/A] referenced existing tickets on Trac with full URL in commit message?
  • checked your Portfile with port lint?
  • [NO] tried existing tests with sudo port test? *
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

* The test framework has issues.

@fhgwright
Copy link
Contributor Author

I'm submitting this as a draft to avoid a competing effort. As it stands, it's known to fail to build on 10.4, 10.7, 10.11, and 10.13, all x86. It's not been tested on PPC at all, since my PPC machine has been tied up with the move to gcc14, which takes a week of build time per OS.

@kimuraw
I assumed you still want to be co-maintainer. If not, I'll delete you.

@fhgwright
Copy link
Contributor Author

BTW, all patches from ruby33 except the gem versioning patch have been upstreamed and included in this version, so the build issues are new problems.

@fhgwright fhgwright force-pushed the ruby34 branch 2 times, most recently from b75b161 to f6aaf75 Compare January 10, 2025 09:36
@fhgwright fhgwright marked this pull request as ready for review January 10, 2025 09:40
@fhgwright
Copy link
Contributor Author

This is now fixed and tested. I force-pushed twice - the first for a rebase-only update, and the second for the real changes since the original draft.

reneeotten
reneeotten reviewed Jan 11, 2025
View reviewed changes
lang/ruby34/Portfile Outdated Show resolved Hide resolved
reneeotten
reneeotten reviewed Jan 11, 2025
View reviewed changes
lang/ruby34/Portfile Outdated Show resolved Hide resolved
@fhgwright
ruby34: New version
93ed0c1 
See:
https://www.ruby-lang.org/en/news/2024/12/25/ruby-3-4-1-released/

The upstream code already incorporates the fixes from v3.2.6, but not
the fixes from 3.2.6_1, which are included in the patchfile here.

The legacy-support threshold is updated for clock_gettime() support.

The upstream linker warning suppression hackery was changed in v3.4 to
somthing badly broken.  This reinstates the 3.3 version, which is
needed for builds to work with certain library mismatches.

Ruby 3.4 does not build with Xcode 10.1 clang 425 on 10.7, so this
blacklists clangs < 500 (in addition to the preexisting blacklisting
of clang 900).

Also cleans up a couple of long-standing Portfile issues.

TESTED:
Built successfully on OSX 10.4-10.5 ppc, 10.4-10.6 i386, 10.5-12.x
x86_64, and 11.x-15.x arm64.  Included all variants compatible with
available dependencies on the respective platforms.
@fhgwright fhgwright changed the title WIP: ruby34: New version ruby34: New version Jan 12, 2025
@fhgwright
Copy link
Contributor Author

Again, two force-pushes, one rebase-only and one with actual changes.
Title fixed as well. :-)

This was fully retested except for limiting PPC testing to the default variant case to save time.

NOTE: There have been some non-repeatable build failures on 10.13, which haven't been consistent enough to easily investigate. We'll see what happens on the buildbot.

@reneeotten reneeotten merged commit 8b34ce8 into macports:master Jan 13, 2025
3 checks passed
@fhgwright fhgwright deleted the ruby34 branch January 13, 2025 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reneeotten reneeotten reneeotten left review comments

Assignees
No one assigned
Labels
type: submission
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fhgwright @reneeotten @macportsbot