Initialize 'check' member in inflateResetKeep() #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids a memory sanitizer warning in adler32_z() where the input adler is undefined due to a call of UPDATE(state->check, strm->next_out - out, out) at line 1269 of inflate.c Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=7541 Credit to OSS-Fuzz
hzhuang1
pushed a commit
to Linaro/warpdrive-zlib
that referenced
this pull request
Jul 31, 2019
This pull request attempts to fix some compiler warnings on Windows when compiled in Release mode. ``` "zlib-ng\ALL_BUILD.vcxproj" (default target) (1) -> "zlib-ng\zlibstatic.vcxproj" (default target) (6) -> zlib-ng\deflate.c(1626): warning C4244: '=': conversion from 'uint16_t' to 'unsigned cha r', possible loss of data [zlib-ng\zlibstatic.vcxproj] zlib-ng\deflate_fast.c(61): warning C4244: '=': conversion from 'uint16_t' to 'unsigned char', possible loss of data [zlib-ng\zlibstatic.vcxproj] zlib-ng\deflate_slow.c(89): warning C4244: '=': conversion from 'uint16_t' to 'unsigned char', possible loss of data [zlib-ng\zlibstatic.vcxproj] ```
|
We are also currently doing this in zlib-ng and has been working well for some time. @madler |
nmoinvaz
approved these changes
Oct 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids a memory sanitizer warning in adler32_z() where the
input adler is undefined due to a call of
UPDATE(state->check, strm->next_out - out, out) at line 1269 of
inflate.c
Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=7541
Credit to OSS-Fuzz