STARK: Better check for texture and bitmap formats

madmoose · Feb 1, 2023 · 962383e · 962383e
1 parent 818797f
commit 962383e
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 9 deletions.
diff --git a/engines/stark/gfx/openglbitmap.cpp b/engines/stark/gfx/openglbitmap.cpp
@@ -60,7 +60,7 @@ void OpenGlBitmap::update(const Graphics::Surface *surface, const byte *palette)
 	_width = surface->w;
 	_height = surface->h;
 
-	if (surface->format.bytesPerPixel != 4) {
+	if (surface->format != Driver::getRGBAPixelFormat()) {
 		// Convert the surface to texture format
 		Graphics::Surface *convertedSurface = surface->convertTo(Driver::getRGBAPixelFormat(), palette);
 
@@ -69,8 +69,6 @@ void OpenGlBitmap::update(const Graphics::Surface *surface, const byte *palette)
 		convertedSurface->free();
 		delete convertedSurface;
 	} else {
-		assert(surface->format == Driver::getRGBAPixelFormat());
-
 		glTexImage2D(GL_TEXTURE_2D, 0, GL_RGBA, surface->w, surface->h, 0, GL_RGBA, GL_UNSIGNED_BYTE, surface->getPixels());
 	}
 }

diff --git a/engines/stark/gfx/opengltexture.cpp b/engines/stark/gfx/opengltexture.cpp
@@ -56,7 +56,7 @@ void OpenGlTexture::bind() const {
 }
 
 void OpenGlTexture::updateLevel(uint32 level, const Graphics::Surface *surface, const byte *palette) {
-	if (surface->format.bytesPerPixel != 4) {
+	if (surface->format != Driver::getRGBAPixelFormat()) {
 		// Convert the surface to texture format
 		Graphics::Surface *convertedSurface = surface->convertTo(Driver::getRGBAPixelFormat(), palette);
 
@@ -65,8 +65,6 @@ void OpenGlTexture::updateLevel(uint32 level, const Graphics::Surface *surface,
 		convertedSurface->free();
 		delete convertedSurface;
 	} else {
-		assert(surface->format == Driver::getRGBAPixelFormat());
-
 		glTexImage2D(GL_TEXTURE_2D, level, GL_RGBA, surface->w, surface->h, 0, GL_RGBA, GL_UNSIGNED_BYTE, surface->getPixels());
 	}
 }

diff --git a/engines/stark/gfx/tinyglbitmap.cpp b/engines/stark/gfx/tinyglbitmap.cpp
@@ -44,14 +44,13 @@ void TinyGlBitmap::update(const Graphics::Surface *surface, const byte *palette)
 	_width = surface->w;
 	_height = surface->h;
 
-	if (surface->format.bytesPerPixel != 4) {
+	if (surface->format != Driver::getRGBAPixelFormat()) {
 		// Convert the surface to bitmap format
 		Graphics::Surface *convertedSurface = surface->convertTo(Driver::getRGBAPixelFormat(), palette);
 		tglUploadBlitImage(_blitImage, *convertedSurface, 0, false);
 		convertedSurface->free();
 		delete convertedSurface;
 	} else {
-		assert(surface->format == Driver::getRGBAPixelFormat());
 		// W/A for 1x1 size bitmap
 		// store pixel color used later fo creating scalled bitmap
 		if (_width == 1 && _height == 1) {

diff --git a/engines/stark/gfx/tinygltexture.cpp b/engines/stark/gfx/tinygltexture.cpp
@@ -51,7 +51,7 @@ void TinyGlTexture::bind() const {
 }
 
 void TinyGlTexture::updateLevel(uint32 level, const Graphics::Surface *surface, const byte *palette) {
-	if (surface->format.bytesPerPixel != 4) {
+	if (surface->format != Driver::getRGBAPixelFormat()) {
 		// Convert the surface to texture format
 		Graphics::Surface *convertedSurface = surface->convertTo(Driver::getRGBAPixelFormat(), palette);