-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Fix admin grid filter backslash escaping issue #39535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix admin grid filter backslash escaping issue #39535
Conversation
Hi @wubinworks. Thank you for your contribution!
Allowed build names are:
You can find more information about the builds here For more details, review the Code Contributions documentation. |
@magento run all tests |
@magento run all tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @wubinworks,
Thanks for making the changes!
Some static tests are still failing, please fix those as well.
Thanks
@magento run all tests |
…ckslash-escaping-issue
@magento run all tests |
Hi @wubinworks, Thanks for the collaboration & contribution! ✔️ QA PassedPreconditions:
Steps to reproduce
Before: ✖️ ![]() After: ✔️ ![]() Builds are failed. Hence, moving this PR to Extended Testing. Thanks. |
…ckslash-escaping-issue
@magento run all tests |
@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE, Integration Tests, Unit Tests |
The Functional B2B failures has one consistent failure and its a known issue. Other failures are inconsistent and flaky. They neither part of PR nor failing because of the PR changes. Known Issue: StorefrontProductNoLongerVisibleInWishlistOnceUserUnassignedFromCompanyTest ACQE-8287 The Functional EE failures are inconsistent and flaky. They neither part of PR nor failing because of the PR changes. Consistent Unit Test Failures are know issue and JIRA has been raised for the same.They neither part of PR nor failing because of the PR changes. Known Issue: https://jira.corp.adobe.com/browse/ACP2E-4051 Hence moving this PR in Merge In Progress. |
9556299
into
magento:2.4-develop
Fixed admin grid filter backslash escaping issue.
Description (*)
The Admin Grid Filter cannot return correct result for keyword that contains backslash. For example
Magento\Store
.This pull request fixed it by escaping backslash.
Related Pull Requests
Fixed Issues (if relevant)
listing component
cannot hit when field value contains\
#39513Manual testing scenarios (*)
Magento\Store
.Magento\Store
in title filter to search and then check the search result.Magento\Store
after merging this branch.Questions or comments
Contribution checklist (*)