Skip to content

Fix admin grid filter backslash escaping issue #39535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

wubinworks
Copy link
Contributor

Fixed admin grid filter backslash escaping issue.

Description (*)

The Admin Grid Filter cannot return correct result for keyword that contains backslash. For example Magento\Store.
This pull request fixed it by escaping backslash.

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes [Small Bug] Filter of Admin Panel listing component cannot hit when field value contains \ #39513

Manual testing scenarios (*)

  1. Create a new block in CMS block admin grid with title Magento\Store.
  2. Input Magento\Store in title filter to search and then check the search result.
  3. The result should contain Magento\Store after merging this branch.

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

Copy link

m2-assistant bot commented Jan 11, 2025

Hi @wubinworks. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@wubinworks
Copy link
Contributor Author

@magento run all tests

@engcom-Bravo engcom-Bravo added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Jan 17, 2025
@ct-prd-projects-boards-automation ct-prd-projects-boards-automation bot moved this from Changes Requested to Review in Progress in Community Dashboard Jun 26, 2025
@wubinworks
Copy link
Contributor Author

@magento run all tests

Copy link
Contributor

@engcom-Hotel engcom-Hotel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @wubinworks,

Thanks for making the changes!

Some static tests are still failing, please fix those as well.

Thanks

@engcom-Hotel engcom-Hotel moved this from Review in Progress to Changes Requested in Community Dashboard Jun 27, 2025
@wubinworks
Copy link
Contributor Author

@magento run all tests

@ct-prd-projects-boards-automation ct-prd-projects-boards-automation bot moved this from Changes Requested to Ready for Testing in Community Dashboard Jun 30, 2025
@ct-prd-projects-boards-automation ct-prd-projects-boards-automation bot moved this from Ready for Testing to Review in Progress in Community Dashboard Jun 30, 2025
@engcom-Hotel engcom-Hotel moved this from Review in Progress to Ready for Testing in Community Dashboard Jun 30, 2025
@engcom-Bravo engcom-Bravo self-assigned this Jul 1, 2025
@engcom-Bravo engcom-Bravo moved this from Ready for Testing to Testing in Progress in Community Dashboard Jul 1, 2025
@engcom-Bravo
Copy link
Contributor

@magento run all tests

@engcom-Bravo
Copy link
Contributor

Hi @wubinworks,

Thanks for the collaboration & contribution!

✔️ QA Passed

Preconditions:

  • Install fresh Magento 2.4-develop

Steps to reproduce

  • Create a new block in CMS block admin grid with title Magento\Store.
  • Input Magento\Store in title filter to search and then check the search result.
  • The result should contain Magento\Store after merging this branch.

Before: ✖️ 

Screenshot 2025-07-01 at 3 13 38 pm

After: ✔️

Screenshot 2025-07-01 at 3 19 04 pm

Builds are failed. Hence, moving this PR to Extended Testing.

Thanks.

@engcom-Bravo engcom-Bravo moved this from Testing in Progress to Extended testing (optional) in Community Dashboard Jul 1, 2025
@engcom-Dash
Copy link
Contributor

@magento run all tests

@engcom-Dash
Copy link
Contributor

@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE, Integration Tests, Unit Tests

@engcom-Dash
Copy link
Contributor

The Functional B2B failures has one consistent failure and its a known issue. Other failures are inconsistent and flaky. They neither part of PR nor failing because of the PR changes.

Build 1: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/39535/f640e9123e4444be84529a623f24ce76/Functional/allure-report-b2b/index.html#categories/8fb3a91ba5aaf9de24cc8a92edc82b5d

image

Build 2: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/39535/581c0dc6c179d036e34c2a3a9306033c/Functional/allure-report-b2b/index.html#categories/bdbf199525818fae7a8651db9eafe741

image

Known Issue: StorefrontProductNoLongerVisibleInWishlistOnceUserUnassignedFromCompanyTest ACQE-8287

The Functional EE failures are inconsistent and flaky. They neither part of PR nor failing because of the PR changes.

Build 1: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/39535/8bec2d6ecbfdfd3f8e16409dca02e33e/Functional/allure-report-ee/index.html#categories/8fb3a91ba5aaf9de24cc8a92edc82b5d

image

Build 2: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/39535/36f2be1c96803a869321072fc866f072/Functional/allure-report-ee/index.html#categories/bdbf199525818fae7a8651db9eafe741

image

Consistent Unit Test Failures are know issue and JIRA has been raised for the same.They neither part of PR nor failing because of the PR changes.

Build 1: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/39535/a299d4232c05dc1e7ececa5621625feb/Unit/console-error-logs.html

image

image

Build 2: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/39535/53b85cfd219f6827ab5f1adfb63233c9/Unit/console-error-logs.html

image

image

Known Issue: https://jira.corp.adobe.com/browse/ACP2E-4051

Hence moving this PR in Merge In Progress.

@engcom-Dash engcom-Dash moved this from Extended testing (optional) to Merge in Progress in Community Dashboard Jul 2, 2025
@magento-devops-reposync-svc magento-devops-reposync-svc merged commit 9556299 into magento:2.4-develop Jul 4, 2025
9 of 12 checks passed
@ct-prd-projects-boards-automation ct-prd-projects-boards-automation bot moved this from Merge in Progress to Recently Merged in Community Dashboard Jul 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Project: Community Picked PRs upvoted by the community
Projects
Status: Recently Merged
Development

Successfully merging this pull request may close these issues.

[Small Bug] Filter of Admin Panel listing component cannot hit when field value contains \
7 participants