#40079 SwiftOtter-SOP-348 Resolve issues with Product listing with negative …

[lbajsarowicz]

Description (*)

PR addresses the negative ?p= value in the Category pagination, that currently results in exception and is considered a valid request.

Related Pull Requests

Fixed Issues (if relevant)

1. Fixes Negative ?p= query string causes ElasticSearch exception #40079

Manual testing scenarios (*)

1. ...
2. ...

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @lbajsarowicz. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

---

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

[lbajsarowicz]

@magento run all tests

[engcom-Hotel]

@magento run all tests

[engcom-Hotel]

Hello @lbajsarowicz,

Thanks for the contribution!

The fix seems good to us, but the fix is only focuses on the product listing page, it would be good if we can implement it for the search page and other product listing page as well.

Also please add some automated test in accordance to the DOD and fix the failed static test failure.

Thanks

[lbajsarowicz]

@magento run all tests

I must express my deep love to MFTF in a current form, where things definitely do not work as anticipated and scope of variable availability is a pure pain.

[lbajsarowicz]

@magento run all test

It turns out that you can't use variables {{}} in regex="" to refer to Page Object.

[magento-automated-testing]

Failed to run the builds. Please try to re-run them later.

[lbajsarowicz]

@magento run all tests

Just try again @magento-automated-testing

[lbajsarowicz]

@magento run all tests

[lbajsarowicz]

@magento run all tests

... MFTF tests sound like fun, but actually it's just wasting the time of contributors. This PR is ready for Code Review and merge for 3 weeks, but since then, I need to handle random issues with MFTF once - twice a day, as the {{ placeholders }} are not handled as expected. Even reusing pieces of tests from other places, where it "works", the process fails to generate tests. It's pure fun, though and definitely encourages me to further contributions. (NOT).