Improve the performance of s-shared-start #134
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This yields a 2-3x speedup on short strings and 5-15x speedup on longer ones on
my machine. I haven't done in-the-wild benchmarking because I don't currently use
s.el
, but I noticed this while reading the implementation. Here's a mico-benchmark:A similar trick could be used for s-shared-end, but I don't know of a way to do it without reversing the input strings (it's still ~2x faster, but it allocates, so the benefit is less clear-cut).
Do you need an update to the contributors list as well for the PR?
Also, I have copyright papers for Emacs on file, if that's needed.