add after_cast method to call ActiveType cast #179
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriscz
suggested changes
Nov 14, 2023
| @@ -0,0 +1,9 @@ | |||
| module ActiveType | |||
There was a problem hiding this comment.
This looks like it's monkey-patching ActiveRecord::Base, but it's embedded under a module for some reason.
I would remove this module and rather check whether the casted object responds to after_cast
| @@ -59,6 +60,9 @@ def cast_record(record, klass, force: false) | |||
| if !force | |||
| make_record_unusable(record) | |||
| end | |||
|
|
|||
| casted.after_cast(record) | |||
There was a problem hiding this comment.
Suggested change
| casted.after_cast(record) | |
| casted.after_cast(record) if casted.respond_to?(:after_cast) |
|
Sorry for the long delay. I've rebased and adjusted this a bit; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there!
Apologies for the delay; I've been quite busy lately. However, I'm now sending the solution that addresses the issue I raised some time ago in the pull request.
#174
The idea is to enable the Active Type Record to have a base method for adding logic after executing the cast. This way, users can easily add business logic as needed.
I hope my contribution will be considered, and I genuinely appreciate your time and attention to this matter. Thank you!