Save exception message when Notification breaks #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbaranay
force-pushed
the
exception-logging
branch
from
6f2d9f6 to
466619f
Compare
nicolasgrasset
suggested changes
Sep 27, 2017
| @@ -85,6 +85,8 @@ class Status(EnumDict): | |||
|
|
|||
| status = models.IntegerField(default=Status.CREATED) | |||
|
|
|||
| exception = models.TextField(blank=True, default='') | |||
There was a problem hiding this comment.
Thanks @pbaranay! Unfortunately, the Notification model is meant to be extremely lean since it's storing 100s of millions of entries in production.
I'd suggest moving this feature to separate table since most notifications shouldn't have any exception anyway!
| self.status = self.Status.BROKEN | ||
| self.exception = "{klass}: {message}".format(klass=e.__class__.__name__, message=str(e)) |
There was a problem hiding this comment.
Arguably, this could be done through a logging system rather than a permanent data store. I think logging would be a more suitable solution to introduce here since it's only assuming you've configured Django for it right now.
Either way you will want to make it configurable with settings. Logging is controlled by logging routes in settings, but if you introduce a new model/field, please add a setting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would be very useful to see the text of the exception that's thrown when sending a notification breaks. Here's a pull request to add a field storing this information to the model. Please let me know what you think!