osd: fix rewewight_by_utilization

Update the incremental, not the in-memory OSDMap! Fixes: ceph#2454 Signed-off-by: Sage Weil <[email protected]>
malbin · May 30, 2012 · 519fadb · 519fadb
1 parent 07498d6
commit 519fadb
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/src/mon/OSDMonitor.cc b/src/mon/OSDMonitor.cc
@@ -326,12 +326,13 @@ int OSDMonitor::reweight_by_utilization(int oload, std::string& out_str)
       // Assign a lower weight to overloaded OSDs. The current weight
       // is a factor to take into account the original weights,
       // to represent e.g. differing storage capacities
-      float weight = osdmap.get_weightf(p->first);
-      float new_weight = (average_util / util) * weight;
-      osdmap.set_weightf(p->first, new_weight);
+      unsigned weight = osdmap.get_weight(p->first);
+      unsigned new_weight = (unsigned)((average_util / util) * (float)weight);
+      pending_inc.new_weight[p->first] = new_weight;
       char buf[128];
       snprintf(buf, sizeof(buf), "%d [%04f -> %04f]", p->first,
-	       weight, new_weight);
+	       (float)weight / (float)0x10000,
+	       (float)new_weight / (float)0x10000);
       oss << buf << sep;
     }
   }