Skip to content

Commit

Permalink
net: ipmr: move pimsm_enabled to pim.h and rename
Browse files Browse the repository at this point in the history
Move the inline pimsm_enabled() to pim.h and rename it to
ipmr_pimsm_enabled to show it's for the ipv4 ipmr code since pim.h is
used by IPv6 too.

Signed-off-by: Nikolay Aleksandrov <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
  • Loading branch information
Nikolay Aleksandrov authored and davem330 committed Nov 30, 2015
1 parent 5ea1f13 commit 1973a4e
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 8 deletions.
5 changes: 5 additions & 0 deletions include/linux/pim.h
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,11 @@

#define PIM_NULL_REGISTER cpu_to_be32(0x40000000)

static inline bool ipmr_pimsm_enabled(void)
{
return IS_BUILTIN(CONFIG_IP_PIMSM_V1) || IS_BUILTIN(CONFIG_IP_PIMSM_V2);
}

/* PIMv2 register message header layout (ietf-draft-idmr-pimvsm-v2-00.ps */
struct pimreghdr
{
Expand Down
11 changes: 3 additions & 8 deletions net/ipv4/ipmr.c
Original file line number Diff line number Diff line change
Expand Up @@ -75,11 +75,6 @@ struct ipmr_result {
struct mr_table *mrt;
};

static inline bool pimsm_enabled(void)
{
return IS_BUILTIN(CONFIG_IP_PIMSM_V1) || IS_BUILTIN(CONFIG_IP_PIMSM_V2);
}

/* Big lock, protecting vif table, mrt cache and mroute socket state.
* Note that the changes are semaphored via rtnl_lock.
*/
Expand Down Expand Up @@ -751,7 +746,7 @@ static int vif_add(struct net *net, struct mr_table *mrt,

switch (vifc->vifc_flags) {
case VIFF_REGISTER:
if (!pimsm_enabled())
if (!ipmr_pimsm_enabled())
return -EINVAL;
/* Special Purpose VIF in PIM
* All the packets will be sent to the daemon
Expand Down Expand Up @@ -1377,7 +1372,7 @@ int ip_mroute_setsockopt(struct sock *sk, int optname, char __user *optval,
mrt->mroute_do_assert = val;
break;
case MRT_PIM:
if (!pimsm_enabled()) {
if (!ipmr_pimsm_enabled()) {
ret = -ENOPROTOOPT;
break;
}
Expand Down Expand Up @@ -1451,7 +1446,7 @@ int ip_mroute_getsockopt(struct sock *sk, int optname, char __user *optval, int
val = 0x0305;
break;
case MRT_PIM:
if (!pimsm_enabled())
if (!ipmr_pimsm_enabled())
return -ENOPROTOOPT;
val = mrt->mroute_do_pim;
break;
Expand Down

0 comments on commit 1973a4e

Please sign in to comment.