Skip to content

Commit

Permalink
Revert "hugetlb: Add hugetlb_dynamic_pool sysctl"
Browse files Browse the repository at this point in the history
This reverts commit 54f9f80 ("hugetlb:
Add hugetlb_dynamic_pool sysctl")

Given the new sysctl nr_overcommit_hugepages, the boolean dynamic pool
sysctl is not needed, as its semantics can be expressed by 0 in the
overcommit sysctl (no dynamic pool) and non-0 in the overcommit sysctl
(pool enabled).

(Needed in 2.6.24 since it reverts a post-2.6.23 userspace-visible change)

Signed-off-by: Nishanth Aravamudan <[email protected]>
Acked-by: Adam Litke <[email protected]>
Cc: William Lee Irwin III <[email protected]>
Cc: Dave Hansen <[email protected]>
Cc: David Gibson <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
  • Loading branch information
Nishanth Aravamudan authored and Linus Torvalds committed Dec 18, 2007
1 parent d1c3fb1 commit 368d2c6
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 14 deletions.
1 change: 0 additions & 1 deletion include/linux/hugetlb.h
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ void hugetlb_unreserve_pages(struct inode *inode, long offset, long freed);

extern unsigned long max_huge_pages;
extern unsigned long hugepages_treat_as_movable;
extern int hugetlb_dynamic_pool;
extern unsigned long nr_overcommit_huge_pages;
extern const unsigned long hugetlb_zero, hugetlb_infinity;
extern int sysctl_hugetlb_shm_group;
Expand Down
8 changes: 0 additions & 8 deletions kernel/sysctl.c
Original file line number Diff line number Diff line change
Expand Up @@ -904,14 +904,6 @@ static struct ctl_table vm_table[] = {
.mode = 0644,
.proc_handler = &hugetlb_treat_movable_handler,
},
{
.ctl_name = CTL_UNNUMBERED,
.procname = "hugetlb_dynamic_pool",
.data = &hugetlb_dynamic_pool,
.maxlen = sizeof(hugetlb_dynamic_pool),
.mode = 0644,
.proc_handler = &proc_dointvec,
},
{
.ctl_name = CTL_UNNUMBERED,
.procname = "nr_overcommit_hugepages",
Expand Down
5 changes: 0 additions & 5 deletions mm/hugetlb.c
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ static unsigned int free_huge_pages_node[MAX_NUMNODES];
static unsigned int surplus_huge_pages_node[MAX_NUMNODES];
static gfp_t htlb_alloc_mask = GFP_HIGHUSER;
unsigned long hugepages_treat_as_movable;
int hugetlb_dynamic_pool;
unsigned long nr_overcommit_huge_pages;
static int hugetlb_next_nid;

Expand Down Expand Up @@ -230,10 +229,6 @@ static struct page *alloc_buddy_huge_page(struct vm_area_struct *vma,
struct page *page;
unsigned int nid;

/* Check if the dynamic pool is enabled */
if (!hugetlb_dynamic_pool)
return NULL;

/*
* Assume we will successfully allocate the surplus page to
* prevent racing processes from causing the surplus to exceed
Expand Down

0 comments on commit 368d2c6

Please sign in to comment.