Skip to content

Commit

Permalink
Kconfig: eliminate "def_bool n" constructs
Browse files Browse the repository at this point in the history
Using "def_bool n" is pointless, simply using bool here appears more
appropriate.

Further, retaining such options that don't have a prompt and aren't
selected by anything seems also at least questionable.

Signed-off-by: Jan Beulich <[email protected]>
Cc: Ingo Molnar <[email protected]>
Cc: Tony Luck <[email protected]>
Cc: Thomas Gleixner <[email protected]>
Cc: Bartlomiej Zolnierkiewicz <[email protected]>
Cc: Sam Ravnborg <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
  • Loading branch information
Jan Beulich authored and torvalds committed Oct 16, 2008
1 parent a25d644 commit 9ba1608
Show file tree
Hide file tree
Showing 7 changed files with 19 additions and 41 deletions.
18 changes: 9 additions & 9 deletions arch/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ config OPROFILE_IBS
If unsure, say N.

config HAVE_OPROFILE
def_bool n
bool

config KPROBES
bool "Kprobes"
Expand All @@ -42,7 +42,7 @@ config KPROBES
If in doubt, say "N".

config HAVE_EFFICIENT_UNALIGNED_ACCESS
def_bool n
bool
help
Some architectures are unable to perform unaligned accesses
without the use of get_unaligned/put_unaligned. Others are
Expand All @@ -65,13 +65,13 @@ config KRETPROBES
depends on KPROBES && HAVE_KRETPROBES

config HAVE_IOREMAP_PROT
def_bool n
bool

config HAVE_KPROBES
def_bool n
bool

config HAVE_KRETPROBES
def_bool n
bool

#
# An arch should select this if it provides all these things:
Expand All @@ -89,16 +89,16 @@ config HAVE_KRETPROBES
# signal delivery calls tracehook_signal_handler()
#
config HAVE_ARCH_TRACEHOOK
def_bool n
bool

config HAVE_DMA_ATTRS
def_bool n
bool

config USE_GENERIC_SMP_HELPERS
def_bool n
bool

config HAVE_CLK
def_bool n
bool
help
The <linux/clk.h> calls support software clock gating and
thus are a key power management tool on many systems.
Expand Down
8 changes: 0 additions & 8 deletions arch/ia64/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -60,14 +60,6 @@ config RWSEM_XCHGADD_ALGORITHM
bool
default y

config ARCH_HAS_ILOG2_U32
bool
default n

config ARCH_HAS_ILOG2_U64
bool
default n

config HUGETLB_PAGE_SIZE_VARIABLE
bool
depends on HUGETLB_PAGE
Expand Down
23 changes: 5 additions & 18 deletions arch/x86/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -39,10 +39,6 @@ config ARCH_DEFCONFIG
default "arch/x86/configs/i386_defconfig" if X86_32
default "arch/x86/configs/x86_64_defconfig" if X86_64


config GENERIC_LOCKBREAK
def_bool n

config GENERIC_TIME
def_bool y

Expand Down Expand Up @@ -95,7 +91,7 @@ config GENERIC_HWEIGHT
def_bool y

config GENERIC_GPIO
def_bool n
bool

config ARCH_MAY_HAVE_PC_FDC
def_bool y
Expand All @@ -106,12 +102,6 @@ config RWSEM_GENERIC_SPINLOCK
config RWSEM_XCHGADD_ALGORITHM
def_bool X86_XADD

config ARCH_HAS_ILOG2_U32
def_bool n

config ARCH_HAS_ILOG2_U64
def_bool n

config ARCH_HAS_CPU_IDLE_WAIT
def_bool y

Expand Down Expand Up @@ -758,9 +748,8 @@ config I8K
Say N otherwise.

config X86_REBOOTFIXUPS
def_bool n
prompt "Enable X86 board specific fixups for reboot"
depends on X86_32 && X86
bool "Enable X86 board specific fixups for reboot"
depends on X86_32
---help---
This enables chipset and/or board specific fixups to be done
in order to get reboot to work correctly. This is only needed on
Expand Down Expand Up @@ -944,8 +933,7 @@ config HIGHMEM
depends on X86_32 && (HIGHMEM64G || HIGHMEM4G)

config X86_PAE
def_bool n
prompt "PAE (Physical Address Extension) Support"
bool "PAE (Physical Address Extension) Support"
depends on X86_32 && !HIGHMEM4G
select RESOURCES_64BIT
help
Expand Down Expand Up @@ -1238,8 +1226,7 @@ config X86_PAT
If unsure, say Y.

config EFI
def_bool n
prompt "EFI runtime service support"
bool "EFI runtime service support"
depends on ACPI
---help---
This enables the kernel to use EFI runtime services that are
Expand Down
2 changes: 1 addition & 1 deletion drivers/ide/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

# Select HAVE_IDE if IDE is supported
config HAVE_IDE
def_bool n
bool

menuconfig IDE
tristate "ATA/ATAPI/MFM/RLL support"
Expand Down
1 change: 0 additions & 1 deletion kernel/time/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
#
config TICK_ONESHOT
bool
default n

config NO_HZ
bool "Tickless System (Dynamic Ticks)"
Expand Down
4 changes: 2 additions & 2 deletions lib/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,10 @@ config BITREVERSE
tristate

config GENERIC_FIND_FIRST_BIT
def_bool n
bool

config GENERIC_FIND_NEXT_BIT
def_bool n
bool

config CRC_CCITT
tristate "CRC-CCITT functions"
Expand Down
4 changes: 2 additions & 2 deletions mm/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ config HAVE_MEMORY_PRESENT
# with gcc 3.4 and later.
#
config SPARSEMEM_STATIC
def_bool n
bool

#
# Architecture platforms which require a two level mem_section in SPARSEMEM
Expand All @@ -113,7 +113,7 @@ config SPARSEMEM_EXTREME
depends on SPARSEMEM && !SPARSEMEM_STATIC

config SPARSEMEM_VMEMMAP_ENABLE
def_bool n
bool

config SPARSEMEM_VMEMMAP
bool "Sparse Memory virtual memmap"
Expand Down

0 comments on commit 9ba1608

Please sign in to comment.