Skip to content

Commit

Permalink
recordmcount: Fix endianness handling bug for nop_mcount
Browse files Browse the repository at this point in the history
In nop_mcount, shdr->sh_offset and welp->r_offset should handle
endianness properly, otherwise it will trigger Segmentation fault
if the recordmcount main and file.o have different endianness.

Link: http://lkml.kernel.org/r/[email protected]

Cc: <[email protected]> # 3.0+
Signed-off-by: Li Bin <[email protected]>
Signed-off-by: Steven Rostedt <[email protected]>
  • Loading branch information
libin2015 authored and rostedt committed Nov 3, 2015
1 parent a15920b commit c84da8b
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion scripts/recordmcount.h
Original file line number Diff line number Diff line change
Expand Up @@ -377,7 +377,7 @@ static void nop_mcount(Elf_Shdr const *const relhdr,

if (mcountsym == Elf_r_sym(relp) && !is_fake_mcount(relp)) {
if (make_nop)
ret = make_nop((void *)ehdr, shdr->sh_offset + relp->r_offset);
ret = make_nop((void *)ehdr, _w(shdr->sh_offset) + _w(relp->r_offset));
if (warn_on_notrace_sect && !once) {
printf("Section %s has mcount callers being ignored\n",
txtname);
Expand Down

0 comments on commit c84da8b

Please sign in to comment.