OSX: Fix selecting item with Up/Down keys when searching

marceepoonu · Apr 4, 2019 · d1cf88a · d1cf88a
1 parent d06ffd4
commit d1cf88a
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/src/gui/filterlineedit.cpp b/src/gui/filterlineedit.cpp
@@ -35,6 +35,7 @@
 #include "gui/icons.h"
 #include "gui/filtercompleter.h"
 
+#include <QKeyEvent>
 #include <QMenu>
 #include <QPainter>
 #include <QSettings>
@@ -172,6 +173,18 @@ void FilterLineEdit::loadSettings()
     }
 }
 
+void FilterLineEdit::keyPressEvent(QKeyEvent *ke)
+{
+    // Up/Down arrow keys should be passed to item list
+    // (on OS X this moves text cursor to the beginning/end).
+    if (ke->key() == Qt::Key_Down || ke->key() == Qt::Key_Up) {
+        ke->ignore();
+        return;
+    }
+
+    FancyLineEdit::keyPressEvent(ke);
+}
+
 void FilterLineEdit::hideEvent(QHideEvent *event)
 {
     FancyLineEdit::hideEvent(event);

diff --git a/src/gui/filterlineedit.h b/src/gui/filterlineedit.h
@@ -50,6 +50,7 @@ class FilterLineEdit final : public FancyLineEdit
     void filterChanged(const QRegExp &);
 
 protected:
+    void keyPressEvent(QKeyEvent *ke) override;
     void hideEvent(QHideEvent *event) override;
     void focusInEvent(QFocusEvent *event) override;
     void focusOutEvent(QFocusEvent *event) override;