Merge pull request woocommerce#1570 from woocommerce/phpcs/tests

Phpcs sniff fixes for unit tests
marcusquiroga · Feb 15, 2019 · 35d31cc · 35d31cc
2 parents f9a69ec + ebbf5c6
commit 35d31cc
Show file tree

Hide file tree

Showing 13 changed files with 164 additions and 150 deletions.
diff --git a/tests/api/admin-notes.php b/tests/api/admin-notes.php
@@ -129,7 +129,7 @@ public function test_get_notes() {
 	public function test_get_warning_notes() {
 		wp_set_current_user( $this->user );
 
-		$request  = new WP_REST_Request( 'GET', $this->endpoint );
+		$request = new WP_REST_Request( 'GET', $this->endpoint );
 		$request->set_query_params( array( 'type' => 'warning' ) );
 		$response = $this->server->dispatch( $request );
 		$notes    = $response->get_data();

diff --git a/tests/api/product-reviews.php b/tests/api/product-reviews.php
@@ -23,7 +23,7 @@ class WC_Tests_API_Product_Reviews extends WC_REST_Unit_Test_Case {
 	public function setUp() {
 		parent::setUp();
 
-		$this->user     = $this->factory->user->create(
+		$this->user = $this->factory->user->create(
 			array(
 				'role' => 'administrator',
 			)
@@ -35,7 +35,7 @@ public function setUp() {
 	 */
 	public function test_product_review_embed() {
 		wp_set_current_user( $this->user );
-		$product    = WC_Helper_Product::create_simple_product();
+		$product = WC_Helper_Product::create_simple_product();
 		WC_Helper_Product::create_product_review( $product->get_id() );
 
 		$request = new WP_REST_Request( 'GET', '/wc/v4/products/reviews' );

diff --git a/tests/api/products.php b/tests/api/products.php
@@ -23,7 +23,7 @@ class WC_Tests_API_Products extends WC_REST_Unit_Test_Case {
 	public function setUp() {
 		parent::setUp();
 
-		$this->user     = $this->factory->user->create(
+		$this->user = $this->factory->user->create(
 			array(
 				'role' => 'administrator',
 			)
@@ -52,7 +52,7 @@ public function test_product_schema() {
 		);
 
 		foreach ( $properties as $property_key => $property ) {
-			if ( in_array( $property_key, $properties_to_embed ) ) {
+			if ( in_array( $property_key, $properties_to_embed, true ) ) {
 				$this->assertEquals( array( 'view', 'edit', 'embed' ), $property['context'] );
 			}
 		}

diff --git a/tests/api/reports-customers-stats.php b/tests/api/reports-customers-stats.php
@@ -40,7 +40,7 @@ public function setUp() {
 	 *
 	 * @since 3.5.0
 	 */
-	public function _test_register_routes() {
+	public function test_register_routes() {
 		$routes = $this->server->get_routes();
 
 		$this->assertArrayHasKey( $this->endpoint, $routes );
@@ -156,8 +156,8 @@ public function test_get_reports() {
 		// Test name and last_order parameters.
 		$request->set_query_params(
 			array(
-				'search'             => 'Jeff',
-				'last_order_after'   => date( 'Y-m-d' ) . 'T00:00:00Z',
+				'search'           => 'Jeff',
+				'last_order_after' => date( 'Y-m-d' ) . 'T00:00:00Z',
 			)
 		);
 		$response = $this->server->dispatch( $request );

diff --git a/tests/api/reports-customers.php b/tests/api/reports-customers.php
@@ -136,7 +136,7 @@ public function test_get_reports() {
 
 		WC_Helper_Queue::run_all_pending();
 
-		$request  = new WP_REST_Request( 'GET', $this->endpoint );
+		$request = new WP_REST_Request( 'GET', $this->endpoint );
 		$request->set_query_params(
 			array(
 				'per_page' => 5,
@@ -175,8 +175,8 @@ public function test_get_reports() {
 		// Test name and last_order parameters.
 		$request->set_query_params(
 			array(
-				'search'             => 'Justin',
-				'last_order_after'   => date( 'Y-m-d' ) . 'T00:00:00Z',
+				'search'           => 'Justin',
+				'last_order_after' => date( 'Y-m-d' ) . 'T00:00:00Z',
 			)
 		);
 		$response = $this->server->dispatch( $request );

diff --git a/tests/api/reports-downloads-stats.php b/tests/api/reports-downloads-stats.php
@@ -77,7 +77,7 @@ public function test_get_report() {
 		$object->set_user_ip_address( '1.2.3.4' );
 		$id = $object->save();
 
-		$time = time();
+		$time    = time();
 		$request = new WP_REST_Request( 'GET', $this->endpoint );
 		$request->set_query_params(
 			array(

diff --git a/tests/api/reports-interval.php b/tests/api/reports-interval.php
@@ -871,9 +871,9 @@ public function test_normalize_between_date_params() {
 		$params   = array( 'a', 'b', 'c', 'd' );
 		$result   = WC_Admin_Reports_Interval::normalize_between_params( $request, $params, true );
 		$expected = array(
-			'b_after' => 1,
+			'b_after'  => 1,
 			'b_before' => 5,
-			'c_after' => 2,
+			'c_after'  => 2,
 			'c_before' => 4,
 		);
 

diff --git a/tests/api/reports-orders-stats.php b/tests/api/reports-orders-stats.php
@@ -61,7 +61,8 @@ public function test_get_reports() {
 
 		$this->assertEquals( 200, $response->get_status() );
 		$this->assertEquals( 2, count( $reports ) ); // totals and intervals.
-		// $this->assertEquals( array(), $reports ); // @todo Update results after implement report interface.
+		// @todo Update results after implement report interface.
+		// $this->assertEquals( array(), $reports ); // @codingStandardsIgnoreLine.
 	}
 
 	/**

diff --git a/tests/api/reports-performance-indicators.php b/tests/api/reports-performance-indicators.php
@@ -86,13 +86,13 @@ public function test_get_indicators() {
 
 		WC_Helper_Queue::run_all_pending();
 
-		$time = time();
+		$time    = time();
 		$request = new WP_REST_Request( 'GET', $this->endpoint );
 		$request->set_query_params(
 			array(
-				'before'   => date( 'Y-m-d 23:59:59', $time ),
-				'after'    => date( 'Y-m-d H:00:00', $time - ( 7 * DAY_IN_SECONDS ) ),
-				'stats' => 'orders/orders_count,downloads/download_count,test/bogus_stat',
+				'before' => date( 'Y-m-d 23:59:59', $time ),
+				'after'  => date( 'Y-m-d H:00:00', $time - ( 7 * DAY_IN_SECONDS ) ),
+				'stats'  => 'orders/orders_count,downloads/download_count,test/bogus_stat',
 			)
 		);
 		$response = $this->server->dispatch( $request );
@@ -126,8 +126,8 @@ public function test_get_indicators_empty_request() {
 		$request = new WP_REST_Request( 'GET', $this->endpoint );
 		$request->set_query_params(
 			array(
-				'before'   => date( 'Y-m-d 23:59:59', $time ),
-				'after'    => date( 'Y-m-d H:00:00', $time - ( 7 * DAY_IN_SECONDS ) ),
+				'before' => date( 'Y-m-d 23:59:59', $time ),
+				'after'  => date( 'Y-m-d H:00:00', $time - ( 7 * DAY_IN_SECONDS ) ),
 			)
 		);
 		$response = $this->server->dispatch( $request );

diff --git a/tests/api/reports-stock-stats.php b/tests/api/reports-stock-stats.php
@@ -74,7 +74,7 @@ public function test_get_reports() {
 			$in_stock->save();
 		}
 
-		$request = new WP_REST_Request( 'GET', $this->endpoint );
+		$request  = new WP_REST_Request( 'GET', $this->endpoint );
 		$response = $this->server->dispatch( $request );
 		$reports  = $response->get_data();
 
@@ -94,7 +94,7 @@ public function test_get_reports() {
 		$backorder_stock->set_stock_status( 'onbackorder' );
 		$backorder_stock->save();
 
-		$request = new WP_REST_Request( 'GET', $this->endpoint );
+		$request  = new WP_REST_Request( 'GET', $this->endpoint );
 		$response = $this->server->dispatch( $request );
 		$reports  = $response->get_data();
 

diff --git a/tests/bootstrap.php b/tests/bootstrap.php
@@ -116,7 +116,7 @@ function _manually_load_plugin() {
  * This matches how we mock the flags in jest.
  */
 function wc_admin_get_feature_config() {
-	$config = json_decode( file_get_contents( dirname( dirname( __FILE__ ) ) . '/config/development.json' ) );
+	$config = json_decode( file_get_contents( dirname( dirname( __FILE__ ) ) . '/config/development.json' ) ); // @codingStandardsIgnoreLine.
 	$flags  = array();
 	foreach ( $config->features as $feature => $bool ) {
 		$flags[ $feature ] = $bool;