Fix non-deterministic logging of unmatched DNS msgs, addresses BIT-1153

Unmatched DNS messages may fail to be logged sometimes due to a type of iterator invalidation.
mareq · Mar 10, 2014 · f30d3e6 · f30d3e6
1 parent 69d52fe
commit f30d3e6
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/scripts/base/protocols/dns/main.bro b/scripts/base/protocols/dns/main.bro
@@ -181,10 +181,9 @@ function log_unmatched_msgs_queue(q: Queue::Queue)
 function log_unmatched_msgs(msgs: PendingMessages)
 	{
 	for ( trans_id in msgs )
-		{
 		log_unmatched_msgs_queue(msgs[trans_id]);
-		delete msgs[trans_id];
-		}
+
+	msgs = PendingMessages();
 	}
 
 function enqueue_new_msg(msgs: PendingMessages, id: count, msg: Info)