Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: marimo islands (Windows-related) + doc touchups #3242

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

Haleshot
Copy link
Contributor

📝 Summary

Will be improving docs for it soon (if that's alright); I believe islands based implementations (conversions, etc) can be elaborated on.

🔍 Description of Changes

  • typo
  • added uv.lock to root .gitignore (generated while islands trying in the repo); can remove if not needed.
  • cross-env package for loading vite server.

📋 Checklist

  • I have read the contributor guidelines.
  • For large changes, or changes that affect the public API: this change was discussed or approved through an issue, on Discord, or the community discussions (Please provide a link if applicable).
  • I have added tests for the changes made.
  • I have run the code and verified that it works as expected.

📜 Reviewers

@akshayka OR @mscolnick

Copy link

vercel bot commented Dec 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marimo-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2024 4:21am

Copy link

vercel bot commented Dec 19, 2024

@Haleshot is attempting to deploy a commit to the marimo Team on Vercel.

A member of the Team first needs to authorize it.

@@ -153,7 +153,7 @@ class MarimoIslandGenerator:
# Example

```python
from marimo.islands import MarimoIslandGenerator
from marimo._islands import MarimoIslandGenerator
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this from marimo.islands import MarimoIslandGenerator broken? ideally they dont need to import private paths

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants