-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: marimo islands (Windows-related) + doc touchups #3242
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@Haleshot is attempting to deploy a commit to the marimo Team on Vercel. A member of the Team first needs to authorize it. |
@@ -153,7 +153,7 @@ class MarimoIslandGenerator: | |||
# Example | |||
|
|||
```python | |||
from marimo.islands import MarimoIslandGenerator | |||
from marimo._islands import MarimoIslandGenerator |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this from marimo.islands import MarimoIslandGenerator
broken? ideally they dont need to import private paths
📝 Summary
Will be improving docs for it soon (if that's alright); I believe islands based implementations (conversions, etc) can be elaborated on.
🔍 Description of Changes
cross-env
package for loading vite server.📋 Checklist
📜 Reviewers
@akshayka OR @mscolnick