Skip to content

Commit

Permalink
Always display the horizontal scroll bar when log word wrap is off
Browse files Browse the repository at this point in the history
Otherwise, a line that's too wide for the log widget will cause the horizontal scroll bar to appear, which reduces the vertical height, and causes the most recent line to be off screen.  Since that line is off screen, the log widget no longer scrolls as new lines appear, unless it's manually scrolled to the very bottom again.
  • Loading branch information
Pokechu22 committed Jan 15, 2020
1 parent 1cc7ef3 commit 0a6a53e
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions Source/Core/DolphinQt/Config/LogWidget.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -184,6 +184,8 @@ void LogWidget::LoadSettings()
m_log_wrap->setChecked(settings.value(QStringLiteral("logging/wraplines")).toBool());
m_log_text->setLineWrapMode(m_log_wrap->isChecked() ? QPlainTextEdit::WidgetWidth :
QPlainTextEdit::NoWrap);
m_log_text->setHorizontalScrollBarPolicy(m_log_wrap->isChecked() ? Qt::ScrollBarAsNeeded :
Qt::ScrollBarAlwaysOn);

// Log - Font Selection
// Currently "Debugger Font" is not supported as there is no Qt Debugger, defaulting to Monospace
Expand All @@ -202,6 +204,8 @@ void LogWidget::SaveSettings()
settings.setValue(QStringLiteral("logging/wraplines"), m_log_wrap->isChecked());
m_log_text->setLineWrapMode(m_log_wrap->isChecked() ? QPlainTextEdit::WidgetWidth :
QPlainTextEdit::NoWrap);
m_log_text->setHorizontalScrollBarPolicy(m_log_wrap->isChecked() ? Qt::ScrollBarAsNeeded :
Qt::ScrollBarAlwaysOn);

// Log - Font Selection
settings.setValue(QStringLiteral("logging/font"), m_log_font->currentIndex());
Expand Down

0 comments on commit 0a6a53e

Please sign in to comment.