Push annotation and attribute info into attributes.md #98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfix-stripe
reviewed
Oct 31, 2022
There was a problem hiding this comment.
r? @lbv-stripe can you rebase this on main now that we have merged your other PR so that the diff is clearer? Thanks!
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Closing in favor of #99 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, we've got two related problems:
This PR addresses those by pushing most attribute and annotation info into /docs/attributes, and by adding language that clarifies that annotations are just an alternate syntax for passing attributes.