Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Setters to tag vars when there are tag params #348

Merged
merged 3 commits into from
Feb 13, 2025

Conversation

LuLaValva
Copy link
Member

Scope

  • Fix setters to tag vars in parent scopes in presence of tag params

Description

This was previously broken:

export interface Input {
  actions: string[]
}

<let/selected=""/>

<for|action| of=input.actions>
  <button onClick() { selected = action; } >
                   // ^? any (should be string)
    click
  </button>
</for>

@LuLaValva LuLaValva self-assigned this Feb 13, 2025
Copy link

changeset-bot bot commented Feb 13, 2025

🦋 Changeset detected

Latest commit: 7499c56

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@marko/language-server Patch
@marko/language-tools Patch
@marko/type-check Patch
marko-vscode Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@LuLaValva LuLaValva merged commit 70494a1 into main Feb 13, 2025
4 checks passed
@LuLaValva LuLaValva deleted the tag-param-parent-scope branch February 13, 2025 22:26
@github-actions github-actions bot mentioned this pull request Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant