Dialog -> Widget, Use signals instead of timer, and code cleanup (#1)

[suniahk]

This originally started out as trying to translate the Dialog UI to a dockable Widget. That turned into "hey, I can replace the timers with signals for a cleaner approach", which turned into "I should fix the UI bug where labels paint over each other". And now here we are. So, without further ado...

• Changed the UI from a dialog to a dockable widget. This also means that the layout is now wrapped in a QScrollArea, so that the UI size never grows too large.
• Removed all timers; code now triggers from source signals instead. QTextEdit boxes update variablesAndValues using the textChanged signal.
• Added checks to make sure UI isn't double-rendered whenever a dependent property changes.
• Stopped triggering a scene collection save on every close; values are now saved to a json file in the module_config_path.
• Finally, the catch-all collective of assorted code-golf and performance optimizations

[marktheminer]

Hi @suniahk I'm on vacation this coming week and I'll try to get to this then. Wondering if these json changes would cover:

#12

[suniahk]

Right now the JSON file is loaded to/from the directory returned from obs_module_config_path, and it's only used to store values on close. It could definitely be adapted to work as an import mechanism, but I think that the obs_data code only supports saving/loading and not watching. Not that we couldn't just do it ourselves, but at that point we're using an api helper function to parse a file into a data format, only to then repeat the overhead every time something changes. It just seems a bit redundant to me.

A better approach could be to adapt the text source approach as seen here. We'd always have the most recent values from the file, we can easily write back using os_quick_write_utf8_file, and as an extra bonus, we're not tied to JSON to structure the data. For user-structured data, I'm definitely more in favor of the .ini format like what was proposed in the issue you linked for the simplicity of it.

[suniahk]

I've updated the code with your suggestions, definitely good catches!

[marktheminer]

Looks like it needs formatting @suniahk

[marktheminer]

@suniahk can you run the formatter?

[marktheminer]

Alternatively @suniahk , if you can tell me the right way to pull your branch and update your PR I can do it. I've not worked with github much prior to these OBS plugins.