db: add support for custom through models in many-to-many fields #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miry
commented
Jan 11, 2025
| @@ -120,8 +122,8 @@ module Marten | |||
| register_field( | |||
| {{ @type }}.new( | |||
| {{ field_id.stringify }}, | |||
| {% unless kwargs.is_a?(NilLiteral) %}**{{ kwargs }}{% end %}, | |||
There was a problem hiding this comment.
This line is not related to the main topic, but I think comma should be present inside the block. It worked because kwargs is not nil, because to is required.
miry
force-pushed
the
13-many-to-many-through-model
branch
from
ede43cd to
1285a53
Compare
miry
commented
Jan 11, 2025
| ) | ||
| end | ||
| {% unless kwargs[:through] %} | ||
| class ::{{ through_model_name.id }} < Marten::DB::Model |
There was a problem hiding this comment.
Here I could actually check if the class resolved and then create dynamic one if it is not defined.
miry
force-pushed
the
13-many-to-many-through-model
branch
from
1285a53 to
d7f2887
Compare
This update allows specifying a custom class for the `through` option in many-to-many relationships, providing greater flexibility in defining intermediate models. Example: ```crystal class Post < Marten::Model # Other fields... field :tags, :many_to_many, to: Tag, through: CustomPostTags end ``` This makes it easier to define and manage custom behavior or attributes within the intermediary model.
miry
force-pushed
the
13-many-to-many-through-model
branch
from
d7f2887 to
57f422b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update allows specifying a custom class for the
throughoption in many-to-many relationships, providing greater flexibility in defining intermediate models.Example:
This makes it easier to define and manage custom behavior or attributes within the intermediary model.
Reference: #13