fixes from code review of PR 212

martinjt · Mar 24, 2015 · 55fd99c · 55fd99c
1 parent 09d1b61
commit 55fd99c
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/CONTRIBUTORS.txt b/CONTRIBUTORS.txt
@@ -8,3 +8,4 @@ Lisa Bylund
 Sebastian Allard
 Jozef Raschmann
 Tor-Bj�rn Holmstr�m
+Stephen Patches
diff --git a/Kentor.AuthServices.Tests/WebSSO/AuthServicesUrlsTests.cs b/Kentor.AuthServices.Tests/WebSSO/AuthServicesUrlsTests.cs
@@ -38,7 +38,7 @@ public void AuthServicesUrls_Ctor_NullCheckApplicationUrl()
         [TestMethod]
         public void AuthServicesUrls_Ctor_NullCheckModulePath()
         {
-            Action a = () => new AuthServicesUrls(new Uri("http://localhost"), (string)null);
+            Action a = () => new AuthServicesUrls(new Uri("http://localhost"), modulePath: null);
 
             a.ShouldThrow<ArgumentNullException>("modulePath");
         }
@@ -103,7 +103,7 @@ public void AuthServicesUrls_Ctor_AllowsNullAcs()
         [TestMethod]
         public void AuthServicesUrls_Ctor_NullCheckSignin()
         {
-            Action a = () => new AuthServicesUrls(new Uri("http://localhost/signin"), (Uri)null);
+            Action a = () => new AuthServicesUrls(new Uri("http://localhost/signin"), signInUrl: null);
 
             a.ShouldThrow<ArgumentNullException>("signInUrl");
         }

diff --git a/Kentor.AuthServices/WebSSO/AuthServicesUrls.cs b/Kentor.AuthServices/WebSSO/AuthServicesUrls.cs
@@ -39,7 +39,8 @@ public AuthServicesUrls(HttpRequestData request, ISPOptions spOptions)
         /// </summary>
         /// <param name="applicationUrl">The full Url to the root of the application.</param>
         /// <param name="modulePath">Path of module, starting with / and ending without.</param>
-        [System.Diagnostics.CodeAnalysis.SuppressMessage( "Microsoft.Design", "CA1057:StringUriOverloadsCallSystemUriOverloads" )]
+        [System.Diagnostics.CodeAnalysis.SuppressMessage( "Microsoft.Design", "CA1057:StringUriOverloadsCallSystemUriOverloads"
+            , Justification = "Incorrect warning. modulePath isn't a string representation of a Uri" )]
         public AuthServicesUrls(Uri applicationUrl, string modulePath)
         {
             if (applicationUrl == null)