since + limit added to parseTrades / parseOrders

js/_1btcxe.js

@@ -180,7 +180,7 @@ module.exports = class _1btcxe extends Exchange {
             'currency': market['id'],
         }, params));
         let trades = this.omit (response['transactions'], 'request_currency');
-        return this.parseTrades (trades, market);
+        return this.parseTrades (trades, market, since, limit);
     }
 
     async createOrder (symbol, type, side, amount, price = undefined, params = {}) {

js/acx.js

@@ -222,7 +222,7 @@ module.exports = class acx extends Exchange {
         }, params));
         // looks like they switched this endpoint off
         // it returns 503 Service Temporarily Unavailable always
-        // return this.parseTrades (response, market);
+        // return this.parseTrades (response, market, since, limit);
         return response;
     }
 

js/base/Exchange.js

@@ -726,7 +726,7 @@ module.exports = class Exchange {
 
     parseOrders (orders, market = undefined, since = undefined, limit = undefined) {
         let result = Object.values (orders).map (order => this.parseOrder (order, market))
-        return this.filterBySinceLimit (result, since, limit)
+        result = this.filterBySinceLimit (result, since, limit)
     }
 
     filterOrdersBySymbol (orders, symbol = undefined) {

js/binance.js

@@ -482,7 +482,7 @@ module.exports = class binance extends Exchange {
         // 'endTime': 789,   // Timestamp in ms to get aggregate trades until INCLUSIVE.
         // 'limit': 500,     // default = maximum = 500
         let response = await this.publicGetAggTrades (this.extend (request, params));
-        return this.parseTrades (response, market);
+        return this.parseTrades (response, market, since, limit);
     }
 
     parseOrderStatus (status) {
@@ -578,7 +578,7 @@ module.exports = class binance extends Exchange {
         if (limit)
             request['limit'] = limit;
         let response = await this.privateGetAllOrders (this.extend (request, params));
-        return this.parseOrders (response, market);
+        return this.parseOrders (response, market, since, limit);
     }
 
     async fetchOpenOrders (symbol = undefined, since = undefined, limit = undefined, params = {}) {
@@ -589,7 +589,7 @@ module.exports = class binance extends Exchange {
         let response = await this.privateGetOpenOrders (this.extend ({
             'symbol': market['id'],
         }, params));
-        return this.parseOrders (response, market);
+        return this.parseOrders (response, market, since, limit);
     }
 
     async cancelOrder (id, symbol = undefined, params = {}) {
@@ -625,7 +625,7 @@ module.exports = class binance extends Exchange {
         if (limit)
             request['limit'] = limit;
         let response = await this.privateGetMyTrades (this.extend (request, params));
-        return this.parseTrades (response, market);
+        return this.parseTrades (response, market, since, limit);
     }
 
     commonCurrencyCode (currency) {

js/bit2c.js

@@ -144,7 +144,7 @@ module.exports = class bit2c extends Exchange {
         let response = await this.publicGetExchangesPairTrades (this.extend ({
             'pair': market['id'],
         }, params));
-        return this.parseTrades (response, market);
+        return this.parseTrades (response, market, since, limit);
     }
 
     async createOrder (symbol, type, side, amount, price = undefined, params = {}) {

js/bitbay.js

@@ -158,7 +158,7 @@ module.exports = class bitbay extends Exchange {
         let response = await this.publicGetIdTrades (this.extend ({
             'id': market['id'],
         }, params));
-        return this.parseTrades (response, market);
+        return this.parseTrades (response, market, since, limit);
     }
 
     async createOrder (symbol, type, side, amount, price = undefined, params = {}) {

js/bitcoincoid.js

@@ -142,7 +142,7 @@ module.exports = class bitcoincoid extends Exchange {
         let response = await this.publicGetPairTrades (this.extend ({
             'pair': market['id'],
         }, params));
-        return this.parseTrades (response, market);
+        return this.parseTrades (response, market, since, limit);
     }
 
     async createOrder (symbol, type, side, amount, price = undefined, params = {}) {

js/bitfinex.js

@@ -315,7 +315,7 @@ module.exports = class bitfinex extends Exchange {
         let response = await this.publicGetTradesSymbol (this.extend ({
             'symbol': market['id'],
         }, params));
-        return this.parseTrades (response, market);
+        return this.parseTrades (response, market, since, limit);
     }
 
     async fetchMyTrades (symbol = undefined, since = undefined, limit = undefined, params = {}) {
@@ -329,7 +329,7 @@ module.exports = class bitfinex extends Exchange {
             request['timestamp'] = parseInt (since / 1000);
         }
         let response = await this.privatePostMytrades (this.extend (request, params));
-        return this.parseTrades (response, market);
+        return this.parseTrades (response, market, since, limit);
     }
 
     async createOrder (symbol, type, side, amount, price = undefined, params = {}) {
@@ -411,9 +411,9 @@ module.exports = class bitfinex extends Exchange {
     async fetchOpenOrders (symbol = undefined, since = undefined, limit = undefined, params = {}) {
         await this.loadMarkets ();
         let response = await this.privatePostOrders (params);
-        let orders = this.parseOrders (response);
+        let orders = this.parseOrders (response, undefined, since, limit);
         if (symbol)
-            return this.filterBy (orders, 'symbol', symbol);
+            orders = this.filterBy (orders, 'symbol', symbol);
         return orders;
     }
 
@@ -423,7 +423,7 @@ module.exports = class bitfinex extends Exchange {
         if (limit)
             request['limit'] = limit;
         let response = await this.privatePostOrdersHist (this.extend (request, params));
-        let orders = this.parseOrders (response);
+        let orders = this.parseOrders (response, undefined, since, limit);
         if (symbol)
             return this.filterBy (orders, 'symbol', symbol);
         return orders;

js/bitfinex2.js

@@ -349,7 +349,7 @@ module.exports = class bitfinex2 extends bitfinex {
             request['limit'] = limit;
         }
         let response = await this.publicGetTradesSymbolHist (this.extend (request, params));
-        return this.parseTrades (response, market);
+        return this.parseTrades (response, market, since, limit);
     }
 
     async fetchOHLCV (symbol, timeframe = '1m', since = undefined, limit = undefined, params = {}) {

js/bitflyer.js

@@ -197,7 +197,7 @@ module.exports = class bitflyer extends Exchange {
         let response = await this.publicGetExecutions (this.extend ({
             'product_code': market['id'],
         }, params));
-        return this.parseTrades (response, market);
+        return this.parseTrades (response, market, since, limit);
     }
 
     async createOrder (symbol, type, side, amount, price = undefined, params = {}) {

js/bithumb.js

@@ -223,7 +223,7 @@ module.exports = class bithumb extends Exchange {
             'currency': market['base'],
             'count': 100, // max = 100
         }, params));
-        return this.parseTrades (response['data'], market);
+        return this.parseTrades (response['data'], market, since, limit);
     }
 
     createOrder (symbol, type, side, amount, price = undefined, params = {}) {

js/bitlish.js

@@ -246,7 +246,7 @@ module.exports = class bitlish extends Exchange {
         let response = await this.publicGetTradesHistory (this.extend ({
             'pair_id': market['id'],
         }, params));
-        return this.parseTrades (response['list'], market);
+        return this.parseTrades (response['list'], market, since, limit);
     }
 
     async fetchBalance (params = {}) {

js/bitmarket.js

@@ -197,7 +197,7 @@ module.exports = class bitmarket extends Exchange {
         let response = await this.publicGetJsonMarketTrades (this.extend ({
             'market': market['id'],
         }, params));
-        return this.parseTrades (response, market);
+        return this.parseTrades (response, market, since, limit);
     }
 
     parseOHLCV (ohlcv, market = undefined, timeframe = '90m', since = undefined, limit = undefined) {

js/bitmex.js

@@ -331,7 +331,7 @@ module.exports = class bitmex extends Exchange {
         let response = await this.publicGetTrade (this.extend ({
             'symbol': market['id'],
         }, params));
-        return this.parseTrades (response, market);
+        return this.parseTrades (response, market, since, limit);
     }
 
     async createOrder (symbol, type, side, amount, price = undefined, params = {}) {

js/bitso.js

@@ -204,7 +204,7 @@ module.exports = class bitso extends Exchange {
         let response = await this.publicGetTrades (this.extend ({
             'book': market['id'],
         }, params));
-        return this.parseTrades (response['payload'], market);
+        return this.parseTrades (response['payload'], market, since, limit);
     }
 
     async createOrder (symbol, type, side, amount, price = undefined, params = {}) {

js/bitstamp.js

@@ -205,7 +205,7 @@ module.exports = class bitstamp extends Exchange {
             'pair': market['id'],
             'time': 'minute',
         }, params));
-        return this.parseTrades (response, market);
+        return this.parseTrades (response, market, since, limit);
     }
 
     async fetchBalance (params = {}) {
@@ -277,7 +277,7 @@ module.exports = class bitstamp extends Exchange {
         let pair = market ? market['id'] : 'all';
         let request = this.extend ({ 'pair': pair }, params);
         let response = await this.privatePostOpenOrdersPair (request);
-        return this.parseTrades (response, market);
+        return this.parseTrades (response, market, since, limit);
     }
 
     async fetchOrder (id, symbol = undefined, params = {}) {

js/bitstamp1.js

@@ -149,7 +149,7 @@ module.exports = class bitstamp1 extends Exchange {
         let response = await this.publicGetTransactions (this.extend ({
             'time': 'minute',
         }, params));
-        return this.parseTrades (response, market);
+        return this.parseTrades (response, market, since, limit);
     }
 
     async fetchBalance (params = {}) {
@@ -214,7 +214,7 @@ module.exports = class bitstamp1 extends Exchange {
         let pair = market ? market['id'] : 'all';
         let request = this.extend ({ 'id': pair }, params);
         let response = await this.privatePostOpenOrdersId (request);
-        return this.parseTrades (response, market);
+        return this.parseTrades (response, market, since, limit);
     }
 
     async fetchOrder (id, symbol = undefined, params = {}) {

js/bittrex.js

@@ -365,7 +365,7 @@ module.exports = class bittrex extends Exchange {
         }, params));
         if ('result' in response) {
             if (typeof response['result'] != 'undefined')
-                return this.parseTrades (response['result'], market);
+                return this.parseTrades (response['result'], market, since, limit);
         }
         throw new ExchangeError (this.id + ' fetchTrades() returned undefined response');
     }
@@ -402,7 +402,7 @@ module.exports = class bittrex extends Exchange {
             request['market'] = market['id'];
         }
         let response = await this.marketGetOpenorders (this.extend (request, params));
-        let orders = this.parseOrders (response['result'], market);
+        let orders = this.parseOrders (response['result'], market, since, limit);
         return this.filterOrdersBySymbol (orders, symbol);
     }
 
@@ -541,7 +541,7 @@ module.exports = class bittrex extends Exchange {
             request['market'] = market['id'];
         }
         let response = await this.accountGetOrderhistory (this.extend (request, params));
-        let orders = this.parseOrders (response['result'], market);
+        let orders = this.parseOrders (response['result'], market, since, limit);
         return this.filterOrdersBySymbol (orders, symbol);
     }
 

js/bl3p.js

@@ -153,7 +153,7 @@ module.exports = class bl3p extends Exchange {
         let response = await this.publicGetMarketTrades (this.extend ({
             'market': market['id'],
         }, params));
-        let result = this.parseTrades (response['data']['trades'], market);
+        let result = this.parseTrades (response['data']['trades'], market, since, limit);
         return result;
     }
 

js/btcbox.js

@@ -163,7 +163,7 @@ module.exports = class btcbox extends Exchange {
         if (numSymbols > 1)
             request['coin'] = market['id'];
         let response = await this.publicGetOrders (this.extend (request, params));
-        return this.parseTrades (response, market);
+        return this.parseTrades (response, market, since, limit);
     }
 
     async createOrder (symbol, type, side, amount, price = undefined, params = {}) {

js/btcchina.js

@@ -267,7 +267,7 @@ module.exports = class btcchina extends Exchange {
         if (market['plus']) {
             return this.parseTradesPlus (response['trades'], market);
         }
-        return this.parseTrades (response, market);
+        return this.parseTrades (response, market, since, limit);
     }
 
     async createOrder (symbol, type, side, amount, price = undefined, params = {}) {

js/btcmarkets.js

@@ -153,7 +153,7 @@ module.exports = class btcmarkets extends Exchange {
             // 'since': 59868345231,
             'id': market['id'],
         }, params));
-        return this.parseTrades (response, market);
+        return this.parseTrades (response, market, since, limit);
     }
 
     async createOrder (symbol, type, side, amount, price = undefined, params = {}) {

js/btctradeua.js

@@ -245,7 +245,7 @@ module.exports = class btctradeua extends Exchange {
                 trades.push (response[i]);
             }
         }
-        return this.parseTrades (trades, market);
+        return this.parseTrades (trades, market, since, limit);
     }
 
     async createOrder (symbol, type, side, amount, price = undefined, params = {}) {
@@ -293,7 +293,7 @@ module.exports = class btctradeua extends Exchange {
             'symbol': market['id'],
         }, params));
         let orders = response['your_open_orders'];
-        return this.parseOrders (orders, market);
+        return this.parseOrders (orders, market, since, limit);
     }
 
     nonce () {

js/btcturk.js

@@ -160,7 +160,7 @@ module.exports = class btcturk extends Exchange {
         let response = await this.publicGetTrades (this.extend ({
             'pairSymbol': market['id'],
         }, params));
-        return this.parseTrades (response, market);
+        return this.parseTrades (response, market, since, limit);
     }
 
     parseOHLCV (ohlcv, market = undefined, timeframe = '1d', since = undefined, limit = undefined) {

js/btcx.js

@@ -124,7 +124,7 @@ module.exports = class btcx extends Exchange {
             'id': market['id'],
             'limit': 1000,
         }, params));
-        return this.parseTrades (response, market);
+        return this.parseTrades (response, market, since, limit);
     }
 
     async createOrder (symbol, type, side, amount, price = undefined, params = {}) {

js/bter.js

@@ -223,7 +223,7 @@ module.exports = class bter extends Exchange {
         let response = await this.publicGetTradeHistoryId (this.extend ({
             'id': market['id'],
         }, params));
-        return this.parseTrades (response['data'], market);
+        return this.parseTrades (response['data'], market, since, limit);
     }
 
     async createOrder (symbol, type, side, amount, price = undefined, params = {}) {

js/bxinth.js

@@ -204,7 +204,7 @@ module.exports = class bxinth extends Exchange {
         let response = await this.publicGetTrade (this.extend ({
             'pairing': market['id'],
         }, params));
-        return this.parseTrades (response['trades'], market);
+        return this.parseTrades (response['trades'], market, since, limit);
     }
 
     async createOrder (symbol, type, side, amount, price = undefined, params = {}) {

js/ccex.js

@@ -217,7 +217,7 @@ module.exports = class ccex extends Exchange {
             'type': 'both',
             'depth': 100,
         }, params));
-        return this.parseTrades (response['result'], market);
+        return this.parseTrades (response['result'], market, since, limit);
     }
 
     async createOrder (symbol, type, side, amount, price = undefined, params = {}) {

js/cex.js

@@ -262,7 +262,7 @@ module.exports = class cex extends Exchange {
         let response = await this.publicGetTradeHistoryPair (this.extend ({
             'pair': market['id'],
         }, params));
-        return this.parseTrades (response, market);
+        return this.parseTrades (response, market, since, limit);
     }
 
     async createOrder (symbol, type, side, amount, price = undefined, params = {}) {
@@ -386,7 +386,7 @@ module.exports = class cex extends Exchange {
         for (let i = 0; i < orders.length; i++) {
             orders[i] = this.extend (orders[i], { 'status': 'open' });
         }
-        return this.parseOrders (orders, market);
+        return this.parseOrders (orders, market, since, limit);
     }
 
     nonce () {

js/coincheck.js

@@ -167,7 +167,7 @@ module.exports = class coincheck extends Exchange {
             throw new NotSupported (this.id + ' fetchTrades () supports BTC/JPY only');
         let market = this.market (symbol);
         let response = await this.publicGetTrades (params);
-        return this.parseTrades (response, market);
+        return this.parseTrades (response, market, since, limit);
     }
 
     async createOrder (symbol, type, side, amount, price = undefined, params = {}) {

js/coinfloor.js

@@ -147,7 +147,7 @@ module.exports = class coinfloor extends Exchange {
         let response = await this.publicGetIdTransactions (this.extend ({
             'id': market['id'],
         }, params));
-        return this.parseTrades (response, market);
+        return this.parseTrades (response, market, since, limit);
     }
 
     async createOrder (symbol, type, side, amount, price = undefined, params = {}) {

js/coingi.js

@@ -248,7 +248,7 @@ module.exports = class coingi extends Exchange {
             'pair': market['id'],
             'maxCount': 128,
         }, params));
-        return this.parseTrades (response, market);
+        return this.parseTrades (response, market, since, limit);
     }
 
     async createOrder (symbol, type, side, amount, price = undefined, params = {}) {