Error on array creation when the ChunkSize is greater than the array size itself #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krisfed
approved these changes
Apr 23, 2025
Zarr.m
Outdated
| @@ -118,6 +118,10 @@ function create(obj, dtype, data_shape, chunk_shape, fillvalue, compression) | |||
| obj.TensorstoreDatatype = obj.TstoredtypeMap(dtype); | |||
| obj.ZarrDatatype = obj.ZarrdtypeMap(dtype); | |||
|
|
|||
| if any(obj.ChunkSize > obj.DsetSize) | |||
| error("Chunk size cannot be greater than size of the data to be written."); | |||
There was a problem hiding this comment.
might be nice to review the errors with Matthew (if not already)?
There was a problem hiding this comment.
Planning to setup an error message catalog. Will run all the error messages by him then.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #30
Earlier, the error was added to zarrwrite only which was an oversight on my end.
Added this check to zarrcreate as well.