Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken Ansible files #56

Merged
merged 4 commits into from
Jan 27, 2023
Merged

Fix broken Ansible files #56

merged 4 commits into from
Jan 27, 2023

Conversation

bimlas
Copy link
Contributor

@bimlas bimlas commented Jan 20, 2023 •
edited
Loading

  • Replace ansible.builtin.shell and ansible.builtin.command by shell
    • Before this modification it shown this error: Unsupported parameters for (command) module: cmd Supported parameters include: ...
  • Add become where needed
  • Update Bor version from 0.3.0 to 0.3.3
  • Fix broken Bor bootnodes list

bimlas added 4 commits January 20, 2023 14:11
@bimlas
Replace ansible.builtin.shell and ansible.builtin.command by shell
2708b11 
Before this modification it shown this error:

Unsupported parameters for (command) module: cmd Supported parameters include: ...
@bimlas
Add become where needed
2fdb163 
Running the installer script needs `sudo` privileges, without this the
playbook hangs forever.
@bimlas
Update Bor version from 0.3.0 to 0.3.3
d63a03b
@bimlas
Fix broken Bor bootnodes list
a6de1ae
@bimlas
Copy link
Contributor Author

bimlas commented Jan 27, 2023

@brixial Can you please check it?

brixial
brixial approved these changes Jan 27, 2023
View reviewed changes
Copy link
Contributor

@brixial brixial left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good thanks for improving it.
Welcome More improvements :)

@brixial brixial merged commit b324270 into maticnetwork:master Jan 27, 2023
@brixial brixial mentioned this pull request Jan 27, 2023
Closed
@bimlas bimlas deleted the fix-broken-ansible-files branch April 24, 2023 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brixial brixial brixial approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bimlas @brixial