Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly display errors & Link external libraries #7

Merged
merged 5 commits into from
Feb 18, 2022
Merged

Properly display errors & Link external libraries #7

merged 5 commits into from
Feb 18, 2022

Conversation

ly0va
Copy link
Member

@ly0va ly0va commented Feb 18, 2022 •
edited
Loading

This PR addresses 2 issues:

  1. Errors from dockerized zksolc are now properly forwarded to hardhat and written to stderr (instead of being displayed as unexpected end of JSON input)
  2. There is a way to link libraries with public/external methods at compile time now. And, therefore, compile projects that use such libraries, since zksolc does not support unlinked objects and linking at the time of deployment.

popzxc
popzxc approved these changes Feb 18, 2022
View reviewed changes
Copy link
Member

@popzxc popzxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

StanislavBreadless
StanislavBreadless approved these changes Feb 18, 2022
View reviewed changes
Copy link
Contributor

@StanislavBreadless StanislavBreadless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

packages/hardhat-zksync-solc/src/compile/docker.ts Outdated Show resolved Hide resolved
@ly0va ly0va merged commit ee460d5 into main Feb 18, 2022
@popzxc popzxc deleted the lyova-link-libraries branch February 18, 2022 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StanislavBreadless StanislavBreadless StanislavBreadless approved these changes

@popzxc popzxc popzxc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ly0va @popzxc @StanislavBreadless