Update benchmark.yml (#206)

* Update benchmark.yml * Update benchmark.yml * Update benchmark.yml * Update benchmark.yml * Update benchmark.yml * Update benchmark_visz.py * Update benchmark.yml * Update benchmark.yml
mattijn · Oct 10, 2023 · 2fdad44 · 2fdad44
1 parent 5ec9e79
commit 2fdad44
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 8 deletions.
diff --git a/.github/workflows/benchmark.yml b/.github/workflows/benchmark.yml
@@ -33,7 +33,6 @@ jobs:
           python-version: "3.10"
       - name: Install test dependencies
         run: |
-          python -m pip install --upgrade pip
           python -m pip install geopandas numpy fire altair vl-convert-python
 
       - name: Install latest topojson version from pypi
@@ -54,9 +53,14 @@ jobs:
       - name: Create visz from benchmark results!
         run: python tests/benchmark_visz.py
 
-      - name: Commit benchmark png
-        uses: EndBug/add-and-commit@v9
-        with:
-          default_author: github_actions
-          message: "generate benchmark chart"
-          add: "tests/benchmark_chart.png --force"
+      - uses: iterative/setup-cml@v2
+      - name: Include benchmark-image as comment to PR
+        env:
+          repo_token: ${{ secrets.GITHUB_TOKEN }}
+        run: |
+          cat <<EOF > benchmark.md
+          #### Benchmark result
+          ![benchmark](./tests/benchmark_chart.svg)  
+          These PR changes are benchmarked against three files, compared with PyPi's latest release and the repository's main branch.
+          EOF
+          cml comment create --publish --pr=false benchmark.md
diff --git a/tests/benchmark_visz.py b/tests/benchmark_visz.py
@@ -33,7 +33,7 @@ def stats_to_visz():
     )
 
     # save chart as png using okab as save method
-    chart.save("tests/benchmark_chart.png", scale_factor=2)
+    chart.save("tests/benchmark_chart.svg", scale_factor=1)
 
 
 if __name__ == "__main__":