Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed CForStmt. Updated parser for ident, var, lets, and switch #271

Merged
merged 4 commits into from
Jul 27, 2018
Merged

Changed CForStmt. Updated parser for ident, var, lets, and switch #271

merged 4 commits into from
Jul 27, 2018

Conversation

MichaelS11
Copy link
Contributor

This has the changes from #268 in it.
Did some rework of switch, so that PR would conflict.

Updated parser ident, var, lets, and switch
Fixed some of the parse errors
Fixed some of the non-parse errors
@codecov-io
Copy link

codecov-io commented Jul 26, 2018

Codecov Report

Merging #271 into master will decrease coverage by 0.34%.
The diff coverage is 95.83%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #271      +/-   ##
==========================================
- Coverage   82.22%   81.87%   -0.35%     
==========================================
  Files           8        8              
  Lines        1879     1876       -3     
==========================================
- Hits         1545     1536       -9     
- Misses        246      256      +10     
+ Partials       88       84       -4
Impacted Files Coverage Δ
vm/vm.go 83.69% <0%> (ø) ⬆️
vm/vmExprFunction.go 69.63% <100%> (ø) ⬆️
vm/vmExpr.go 81.89% <100%> (-1.82%) ⬇️
vm/vmStmt.go 82.9% <100%> (+1.23%) ⬆️
vm/vmConvertToX.go 55.38% <80%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a01259...34abc94. Read the comment docs.

@MichaelS11
Copy link
Contributor Author

This is a first pass on fixing some of the parsing of var/let in the for loop. Got side tracked into the switch code.

Thought it would be good to merge before too much code change.

@MichaelS11
Copy link
Contributor Author

Fix when map item is not found it is not equal to nil and should be.
#272

@mattn mattn merged commit 959fc4f into mattn:master Jul 27, 2018
@mattn
Copy link
Owner

mattn commented Jul 27, 2018

Thank you

@MichaelS11 MichaelS11 deleted the test branch July 27, 2018 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants