Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable go modules #28

Merged
merged 1 commit into from
Feb 22, 2019
Merged

Enable go modules #28

merged 1 commit into from
Feb 22, 2019

Conversation

radeksimko
Copy link
Contributor

Go modules are becoming a de-facto standard in the Go community and adding go.mod files with metadata helps projects which may consume this repository as a dependency in deciding how to pin transitive dependencies and how to resolve conflicts.

This is a result of the following commands:

go mod init
go get ./...
go mod tidy

in a clean Go 1.11.5 environment.

@mattn
Copy link
Owner

mattn commented Feb 22, 2019

Thank you. I've better to merge #25 before this.

@radeksimko
Copy link
Contributor Author

@mattn I'm happy to rebase & re-run the above commands for you after you merge that PR. Just ping me whenever you're ready. 😉

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 18d4608 on radeksimko:go-mod into 3fb116b on mattn:master.

@mattn
Copy link
Owner

mattn commented Feb 22, 2019

Merged #25 go-isatty is already depend on x/sys. So can I merge this without rebase?

@radeksimko
Copy link
Contributor Author

@mattn Ah, sure, I didn't realize that. It's safe to merge as is then! 😄

@mattn mattn merged commit a6dda38 into mattn:master Feb 22, 2019
@mattn
Copy link
Owner

mattn commented Feb 22, 2019

Thanks!

@radeksimko radeksimko deleted the go-mod branch February 22, 2019 15:23
@radeksimko
Copy link
Contributor Author

Thanks for a quick review & merge @mattn

It would be great if you could cut v0.0.5 with this patch as Go Modules strictly follow semantic versioning and the new version (with this patch) otherwise isn't discoverable via go get -u and other ways.

@mattn
Copy link
Owner

mattn commented Feb 22, 2019

Tagged. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants