env: mmc: Fix offset issue for env save

Fix the issue in commit 46c9016 ("env: mcc: Drop unnecessary #ifdefs") If CONFIG_SYS_REDUNDAND_ENVIRONMENT is not defined, the offset value becomes undetermined, so write env to unexpected offset. Signed-off-by: Ye Li <[email protected]> Reviewed-by: Jaehoon Chung <[email protected]>
matwey · Feb 6, 2023 · ccd0542 · ccd0542
1 parent 94a51af
commit ccd0542
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/env/mmc.c b/env/mmc.c
@@ -273,11 +273,11 @@ static int env_mmc_save(void)
 			if (ret)
 				goto fini;
 		}
+	}
 
-		if (mmc_get_env_addr(mmc, copy, &offset)) {
-			ret = 1;
-			goto fini;
-		}
+	if (mmc_get_env_addr(mmc, copy, &offset)) {
+		ret = 1;
+		goto fini;
 	}
 
 	printf("Writing to %sMMC(%d)... ", copy ? "redundant " : "", dev);