refactor: increase performance by ~7% thanks to Tokens::block*Cache…

… hit increased by ~12% (PHP-CS-Fixer#6176)
maxhelias · Jan 9, 2024 · fc00ff1 · fc00ff1
1 parent 8818ab7
commit fc00ff1
Showing 1 changed file with 21 additions and 8 deletions.
diff --git a/src/Tokenizer/Tokens.php b/src/Tokenizer/Tokens.php
@@ -295,10 +295,18 @@ public function setSize($size): bool
      */
     public function offsetUnset($index): void
     {
-        $this->changed = true;
-        $this->namespaceDeclarations = null;
         if (isset($this[$index])) {
+            if (isset($this->blockStartCache[$index])) {
+                unset($this->blockEndCache[$this->blockStartCache[$index]], $this->blockStartCache[$index]);
+            }
+            if (isset($this->blockEndCache[$index])) {
+                unset($this->blockStartCache[$this->blockEndCache[$index]], $this->blockEndCache[$index]);
+            }
+
             $this->unregisterFoundToken($this[$index]);
+
+            $this->changed = true;
+            $this->namespaceDeclarations = null;
         }
 
         parent::offsetUnset($index);
@@ -314,16 +322,21 @@ public function offsetUnset($index): void
      */
     public function offsetSet($index, $newval): void
     {
-        $this->blockStartCache = [];
-        $this->blockEndCache = [];
-
         if (!isset($this[$index]) || !$this[$index]->equals($newval)) {
-            $this->changed = true;
-            $this->namespaceDeclarations = null;
-
             if (isset($this[$index])) {
+                if (isset($this->blockStartCache[$index])) {
+                    unset($this->blockEndCache[$this->blockStartCache[$index]], $this->blockStartCache[$index]);
+                }
+                if (isset($this->blockEndCache[$index])) {
+                    unset($this->blockStartCache[$this->blockEndCache[$index]], $this->blockEndCache[$index]);
+                }
+
                 $this->unregisterFoundToken($this[$index]);
             }
+
+            $this->changed = true;
+            $this->namespaceDeclarations = null;
+
             $this->registerFoundToken($newval);
         }