Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/frontend loading #32

Merged
merged 3 commits into from
Dec 7, 2024
Merged

Fix/frontend loading #32

merged 3 commits into from
Dec 7, 2024

Conversation

IsaacGemal
Copy link
Collaborator

Some minor tweaks

  • Added some auth console logs to make things easier to see for debugging purposes.
  • We can (and should) remove them later.
  • Infinite comparison bug fix (per your PR)
  • Replaced the infinite spinner with a "No comparisons available right now", I found that confusing with no message being shown.

Not entirely fixes but just some QOL stuff

huntcsg
huntcsg approved these changes Dec 7, 2024
View reviewed changes
Copy link
Contributor

@huntcsg huntcsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ship it 🚢

@IsaacGemal IsaacGemal merged commit be99089 into main Dec 7, 2024
1 check passed
@IsaacGemal IsaacGemal deleted the fix/frontend-loading branch December 7, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huntcsg huntcsg huntcsg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IsaacGemal @huntcsg