memoize computationally expensive calls

mcaulifn · Feb 9, 2015 · c23bc1a · c23bc1a
1 parent 8b95613
commit c23bc1a
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/app/scripts/modules/account/accountService.js b/app/scripts/modules/account/accountService.js
@@ -79,7 +79,7 @@ angular.module('deckApp.account.service', [
       });
     }
 
-    function getRegionsKeyedByAccount() {
+    var getRegionsKeyedByAccount = _.memoize(function() {
       var deferred = $q.defer();
       listAccounts().then(function(accounts) {
         $q.all(accounts.reduce(function(acc, account) {
@@ -94,7 +94,7 @@ angular.module('deckApp.account.service', [
         });
       });
       return deferred.promise;
-    }
+    });
 
     function getAccountDetails(accountName) {
       return Restangular.one('credentials', accountName)

diff --git a/app/scripts/services/awsInstanceTypeService.js b/app/scripts/services/awsInstanceTypeService.js
@@ -252,7 +252,7 @@ angular.module('deckApp.aws.instanceType.service', [
       return $q.when(categories);
     }
 
-    function getAllTypesByRegion() {
+    var getAllTypesByRegion = _.memoize(function getAllTypesByRegion() {
 
       var instanceTypesEndpoint = Restangular.withConfig(function (RestangularConfigurer) {
         RestangularConfigurer.setDefaultHttpFields({cache: true});
@@ -261,7 +261,7 @@ angular.module('deckApp.aws.instanceType.service', [
       return instanceTypesEndpoint.all('instanceTypes').getList().then(function (types) {
         return _.groupBy(types, 'region');
       });
-    }
+    });
 
     function getAvailableTypesForRegions(availableRegions, selectedRegions) {
       selectedRegions = selectedRegions || [];