Skip to content

Commit

Permalink
tests/test-char.c: Wait for the chardev to connect in char_socket_cli…
Browse files Browse the repository at this point in the history
…ent_dupid_test

A connecting chardev object has an additional reference by the connecting
thread, so if the chardev is still connecting by the end of the test,
then the chardev object won't be freed. This in turn means that the yank
instance won't be unregistered and when running the next test-case
yank_register_instance will abort, because the yank instance is
already/still registered.

Signed-off-by: Lukas Straub <[email protected]>
Reviewed-by: Daniel P. Berrangé <[email protected]>
Message-Id: <1445e97a5800e3f2ba024ad52b500a0315701632.1609167865.git.lukasstraub2@web.de>
Signed-off-by: Markus Armbruster <[email protected]>
  • Loading branch information
lukasstraub2 authored and Markus Armbruster committed Jan 13, 2021
1 parent 8659f31 commit 91d48e5
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions tests/test-char.c
Original file line number Diff line number Diff line change
Expand Up @@ -937,6 +937,7 @@ static void char_socket_client_dupid_test(gconstpointer opaque)
g_assert_nonnull(opts);
chr1 = qemu_chr_new_from_opts(opts, NULL, &error_abort);
g_assert_nonnull(chr1);
qemu_chr_wait_connected(chr1, &error_abort);

chr2 = qemu_chr_new_from_opts(opts, NULL, &local_err);
g_assert_null(chr2);
Expand Down

0 comments on commit 91d48e5

Please sign in to comment.