Skip to content

Commit

Permalink
WFE: Only log warnings for non-limit errors (letsencrypt#7717)
Browse files Browse the repository at this point in the history
Only log errors from `wfe.checkNewOrderLimits` and
`wfe.checkNewAccountLimits` if they're not `errors.RateLimit`.
  • Loading branch information
beautifulentropy authored Sep 26, 2024
1 parent 8c009f2 commit 3451952
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions wfe2/wfe.go
Original file line number Diff line number Diff line change
Expand Up @@ -801,8 +801,9 @@ func (wfe *WebFrontEndImpl) NewAccount(
wfe.sendError(response, logEvent, probs.RateLimited(err.Error()), err)
return
}
} else {
wfe.log.Warning(err.Error())
}
wfe.log.Warning(err.Error())
}

var newRegistrationSuccessful bool
Expand Down Expand Up @@ -2383,8 +2384,9 @@ func (wfe *WebFrontEndImpl) NewOrder(
wfe.sendError(response, logEvent, probs.RateLimited(err.Error()), err)
return
}
} else {
wfe.log.Warning(err.Error())
}
wfe.log.Warning(err.Error())
}

var newOrderSuccessful bool
Expand Down

0 comments on commit 3451952

Please sign in to comment.